From owner-svn-src-all@freebsd.org Thu May 21 15:12:56 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8BFEC2DBBDF; Thu, 21 May 2020 15:12:56 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49SY5g6vffz3d3Z; Thu, 21 May 2020 15:12:55 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x741.google.com with SMTP id i5so7463050qkl.12; Thu, 21 May 2020 08:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VKCEuJYJ8YkIe1lbAvbVynDVmPPNWye5Fcme50TyaFI=; b=DAmGUb81wBfKzkEh+jhtdlO7F5svt1PbyvvTiSm/TFeoEK1LSxP3D+1stxTXVVGppF cjRBr9aUXpEkuTDRh3ud95psC8t57PtF/PBk29wrq/oBlurWuNO/Tqp+TH/s+QMfSciS KVAEBunK4siNZgchqKH3zufEcJ639UbGpiljeN/xysQXiB6E6MN6gJbKOR6hyIG16b6n vtx+w1ziv7LAdxwgj/dmZUk6bmTFgGC06umpeWzFWK4qNfUp6R8jFyV5bClbFYNdxIGt jMRKp+W3WrkRnfRa4+hgq/W5p+2gsLCY6XOzGf+o81/Qbc+5kbm25Udttrr1ZYwaoe0g UGUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=VKCEuJYJ8YkIe1lbAvbVynDVmPPNWye5Fcme50TyaFI=; b=P34/WFwQWsV4emwdQB2Y0nPopms/Q9tG2VJxycW39GgZDCm/BXqeBeNIW0wzSc1a3H Jnv2pFixEW+/U1DFbyYAQXpU5LvmbYBPeGuSR4r705dSaN4K8tjbZIrOOrs/kIA3WHZp fPkqCnrAThV1cEpqruDfgne0/CC7Ab6L3dVretBe2Vcf2pz8Jqo6Ig2smUXJiJRaVRzk 6MAJ2EtpwWmMQ4Rycn09BKDtmWZZkwdbyuPxJ3VsNtPtgU7CuZz8BCz5fpyKLp5gVhuo yRlySvkGiPRTMr/pQ4e2Q0TgP7OnvzYJbBtwm9EYmggw7Hq7gK+Keq7evB1Y/x64VgQE oHLg== X-Gm-Message-State: AOAM533no2uFsL7M7Qn7BgW7/HPQv7f7jUyAN67HxeD9ehjoV8Ra09tA GNYfZheKjjHOAbhlWoyExoI= X-Google-Smtp-Source: ABdhPJwWNILCxg07NoBurZlGiuZ75NApEQIKJGQyHl+cJiKowiXnSdOAI0IM9FX6kYUlxKeagTllvA== X-Received: by 2002:a05:620a:1455:: with SMTP id i21mr9947083qkl.124.1590073975017; Thu, 21 May 2020 08:12:55 -0700 (PDT) Received: from raichu (toroon0560w-lp130-15-184-144-87-103.dsl.bell.ca. [184.144.87.103]) by smtp.gmail.com with ESMTPSA id i3sm5063665qkf.39.2020.05.21.08.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 08:12:53 -0700 (PDT) Sender: Mark Johnston Date: Thu, 21 May 2020 11:12:48 -0400 From: Mark Johnston To: Konstantin Belousov Cc: Antoine Brodin , jhb@freebsd.org, src-committers , svn-src-all , svn-src-head@freebsd.org Subject: Re: svn commit: r361303 - in head: lib/libc/gen libexec/rtld-elf sys/sys Message-ID: <20200521151248.GA85681@raichu> References: <202005202208.04KM8QPA020707@repo.freebsd.org> <20200521134152.GE64045@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200521134152.GE64045@kib.kiev.ua> X-Rspamd-Queue-Id: 49SY5g6vffz3d3Z X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=DAmGUb81; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::741 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-0.74 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.66)[-0.661]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-0.41)[-0.406]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.03)[0.029]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::741:from]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[184.144.87.103:received]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 15:12:56 -0000 On Thu, May 21, 2020 at 04:41:52PM +0300, Konstantin Belousov wrote: > On Thu, May 21, 2020 at 03:02:07PM +0200, Antoine Brodin wrote: > > On Thu, May 21, 2020 at 12:08 AM Konstantin Belousov wrote: > > > > > > Author: kib > > > Date: Wed May 20 22:08:26 2020 > > > New Revision: 361303 > > > URL: https://svnweb.freebsd.org/changeset/base/361303 > > > > > > Log: > > > Change the samantic of struct link_map l_addr member. > > > > > > It previously returned the object map base address, while all other > > > ELF operating systems return load offset, i.e. the difference between > > > map base and the link base. > > > > > > Explain the meaning of the field in the man page. > > > > > > Stop filling the mips-only l_offs member, which is apparently unused. > > > > > > PR: 246561 > > > Requested by: Damjan Jovanovic > > > Reviewed by: emaste, jhb, cem (previous version) > > > Sponsored by: The FreeBSD Foundation > > > MFC after: 1 week > > > Differential revision: https://reviews.freebsd.org/D24918 > > > > > > Modified: > > > head/lib/libc/gen/dlinfo.3 > > > head/libexec/rtld-elf/rtld.c > > > head/sys/sys/link_elf.h > > > > Hi, > > > > After this commit, some ports fail to build with signal 11. > > For instance lang/perl5.30 fails to build with default options (DTRACE on) > > Disabling the DTRACE option makes it able to build again. > > > I see, thank you for reporting. > > So drti.c:dtrace_dof_init() does read l_addr, and the dtrace code assumes > that l_addr is the base, not relocbase. > > Mark, was dofhp_addr initialization changed comparing to Solaris ? It appears it has been the same since DTrace was imported. illumos still has similar code. Note that drti.o is linked into any executable and shlib that defines static probes, so the ABI change affects more than just dtrace(1). Would it be possible to define a new value for RTLD_DI_LINKMAP, and preserve the old behaviour for the old value?