From owner-freebsd-bugs@FreeBSD.ORG  Wed Jan 14 11:22:15 2015
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 78D21822
 for <freebsd-bugs@FreeBSD.org>; Wed, 14 Jan 2015 11:22:15 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 46802214
 for <freebsd-bugs@FreeBSD.org>; Wed, 14 Jan 2015 11:22:15 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t0EBMFu1091152
 for <freebsd-bugs@FreeBSD.org>; Wed, 14 Jan 2015 11:22:15 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 196718] kern_fcntl_freebsd() spills beyond old lock structure
Date: Wed, 14 Jan 2015 11:22:15 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 10.1-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: walter@pelissero.de
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-196718-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jan 2015 11:22:15 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196718

            Bug ID: 196718
           Summary: kern_fcntl_freebsd() spills beyond old lock structure
           Product: Base System
           Version: 10.1-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: walter@pelissero.de

>From a look at kern_fcntl_freebsd() it seems to me that the old lock structure
is not properly filled in case of the F_OGETLK operation.
This should fix the bug:


--- kern_descrip.c    (revision 276910)
+++ kern_descrip.c    (working copy)
@@ -419,8 +419,10 @@
     struct __oflock ofl;
     intptr_t arg1;
     int error;
+    int newcmd;

     error = 0;
+    newcmd = cmd;
     switch (cmd) {
     case F_OGETLK:
     case F_OSETLK:
@@ -438,13 +440,13 @@

         switch (cmd) {
         case F_OGETLK:
-            cmd = F_GETLK;
+            newcmd = F_GETLK;
             break;
         case F_OSETLK:
-            cmd = F_SETLK;
+            newcmd = F_SETLK;
             break;
         case F_OSETLKW:
-            cmd = F_SETLKW;
+            newcmd = F_SETLKW;
             break;
         }
         arg1 = (intptr_t)&fl;
@@ -462,7 +464,7 @@
     }
     if (error)
         return (error);
-    error = kern_fcntl(td, fd, cmd, arg1);
+    error = kern_fcntl(td, fd, newcmd, arg1);
     if (error)
         return (error);
     if (cmd == F_OGETLK) {

-- 
You are receiving this mail because:
You are the assignee for the bug.