From owner-svn-ports-all@freebsd.org  Thu Jul 26 07:08:58 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A8D91044CA9;
 Thu, 26 Jul 2018 07:08:58 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5413781F0C;
 Thu, 26 Jul 2018 07:08:58 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 43B12167AD; Thu, 26 Jul 2018 07:08:58 +0000 (UTC)
Date: Thu, 26 Jul 2018 07:08:58 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Yuri <yuri@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r475335 - head/devel/liteide
Message-ID: <20180726070858.GA93790@FreeBSD.org>
References: <201807252025.w6PKPsxQ097871@repo.freebsd.org>
 <20180726064408.GC77261@FreeBSD.org>
 <32e60b17-116f-e431-872b-903412e4abd1@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <32e60b17-116f-e431-872b-903412e4abd1@freebsd.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2018 07:08:58 -0000

On Thu, Jul 26, 2018 at 12:02:27AM -0700, Yuri wrote:
> On 7/25/18 11:44 PM, Alexey Dokuchaev wrote:
> >> ...
> >> +FLAVORS=	qt5 qt4
> >> +FLAVOR?=	${FLAVORS:[1]}
> > Is this line needed in this case?
> 
> Section 7.2 of PHB recommends this line:
> https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html

Yes, I know, but as long as you never check against the default FLAVOR,
you don't need it.

> > Because qt5 is default flavor, and you're checking for qt4 first (qt5 is
> > in .else branch) and never for .if ${FLAVOR} == qt5.
> 
> Framework checks that flavor is in the list. Here, when flavor isn't
> qt4, it is safe to assume that it is qt5.

Thank you captain.  Not sure why you had to explain this, but that does
not change the point that you don't need FLAVOR?=${FLAVORS:[1]}.  :U
will protect you from undefined variable, and it would be defined in the
Qt4 case because it's not the default flavor.

./danfe