From owner-cvs-src@FreeBSD.ORG Mon Apr 21 21:55:55 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 207FB1065670; Mon, 21 Apr 2008 21:55:55 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id DEB368FC19; Mon, 21 Apr 2008 21:55:54 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id B58A517105; Mon, 21 Apr 2008 21:55:53 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.2/8.14.2) with ESMTP id m3LLtrAp099532; Mon, 21 Apr 2008 21:55:53 GMT (envelope-from phk@critter.freebsd.dk) To: John-Mark Gurney From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 21 Apr 2008 14:37:25 MST." <20080421213724.GL82555@funkthat.com> Date: Mon, 21 Apr 2008 21:55:53 +0000 Message-ID: <99531.1208814953@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, "Bjoern A. Zeeb" , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Apr 2008 21:55:55 -0000 In message <20080421213724.GL82555@funkthat.com>, John-Mark Gurney writes: >Any one object to changing: >.Nm devclass_get_maxunit >.Nd find the maximum unit number in the class > >to: >.Nm devclass_get_maxunit >.Nd find the next free unit number in the class Those are very different semantics, the name should change as well then. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.