From owner-freebsd-net@FreeBSD.ORG Wed Jan 24 06:10:07 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 95E1616A401 for ; Wed, 24 Jan 2007 06:10:07 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-5.cisco.com (sj-iport-5.cisco.com [171.68.10.87]) by mx1.freebsd.org (Postfix) with ESMTP id 5CE5313C44C for ; Wed, 24 Jan 2007 06:10:07 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-5.cisco.com ([171.68.10.79]) by sj-iport-5.cisco.com with ESMTP; 23 Jan 2007 22:10:07 -0800 Received: from sj-core-1.cisco.com (sj-core-1.cisco.com [171.71.177.237]) by sj-dkim-5.cisco.com (8.12.11/8.12.11) with ESMTP id l0O6A6GQ011011; Tue, 23 Jan 2007 22:10:06 -0800 Received: from xbh-sjc-211.amer.cisco.com (xbh-sjc-211.cisco.com [171.70.151.144]) by sj-core-1.cisco.com (8.12.10/8.12.6) with ESMTP id l0O6A6Dk019768; Tue, 23 Jan 2007 22:10:06 -0800 (PST) Received: from xfe-sjc-211.amer.cisco.com ([171.70.151.174]) by xbh-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 23 Jan 2007 22:10:06 -0800 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 23 Jan 2007 22:10:05 -0800 Message-ID: <45B6F81C.6050802@cisco.com> Date: Wed, 24 Jan 2007 01:09:32 -0500 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061029 FreeBSD/i386 SeaMonkey/1.0.6 MIME-Version: 1.0 To: Bruce Evans References: <45B679F3.3080407@cisco.com> <20070124150524.P16439@besplex.bde.org> In-Reply-To: <20070124150524.P16439@besplex.bde.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 24 Jan 2007 06:10:05.0898 (UTC) FILETIME=[4AEF62A0:01C73F7E] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=792; t=1169619006; x=1170483006; c=relaxed/simple; s=sjdkim5002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20mbuf=20patch=20with=20sysctl=20suggestions=20too |Sender:=20; bh=/LRSHl8f1rd4AvFZtjpcXRErsn+bCQKwZlmi8Sn+S4Q=; b=Q++HzgVdq/Oqogfa/++7XmPqg6F3Mh4F0gBzsLUf269E/r68SE66KwcEmFDFCpmKS0fi3rlK MqKt+TrZF4KiUqR45iRUWqaKh6D/nkXoqU+jg+otjCiJ7woMgrEFWZ4w; Authentication-Results: sj-dkim-5; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim5002 verified; ); Cc: freebsd-net Subject: Re: mbuf patch with sysctl suggestions too X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2007 06:10:07 -0000 Bruce Evans wrote: > On Tue, 23 Jan 2007, Randall Stewart wrote: > >> Here is iteration 2 of the mbuf patch with limits I >> proposed. >> >> Also note the changes for sysctl stuff that Lugi suggested. >> Please let me know what you think :-) > > It has a lot of style bugs (4 per line on so,me lines) (mainly weird > whitespace starting with tab lossage). > > Bruce > That has to do with me using emacs I think.. I will be running that section of code through the style9 (s9indent) stuff that George gave me... so that should take care of the space <-> tab issues and other stuff... I think Pyun is right though.. in adding the page size calculation to the init code.. R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)