From owner-freebsd-stable@freebsd.org Sat Jan 30 17:26:22 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAEB9A73806 for ; Sat, 30 Jan 2016 17:26:22 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "alchemy.franken.de", Issuer "alchemy.franken.de" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 69E011471 for ; Sat, 30 Jan 2016 17:26:22 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.15.2/8.15.2/ALCHEMY.FRANKEN.DE) with ESMTPS id u0UHQI9t025467 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 30 Jan 2016 18:26:18 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.15.2/8.15.2/Submit) id u0UHQIYQ025466; Sat, 30 Jan 2016 18:26:18 +0100 (CET) (envelope-from marius) Date: Sat, 30 Jan 2016 18:26:18 +0100 From: Marius Strobl To: Mike Tancsa Cc: FreeBSD-STABLE Mailing List Subject: Re: possible em regression (was Re: svn commit: r294958 - in stable/10: share/man/man4 sys/dev/e1000 sys/dev/ixgb sys/dev/netmap) Message-ID: <20160130172618.GA15359@alchemy.franken.de> References: <201601272231.u0RMV8LW019394@repo.freebsd.org> <56ABAA92.5050901@sentex.net> <56ABB291.5040305@omnilan.de> <56ABCE95.3030807@sentex.net> <20160130012358.GY15359@alchemy.franken.de> <56ACE917.80502@sentex.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="9Iq5ULCa7nGtWwZS" Content-Disposition: inline In-Reply-To: <56ACE917.80502@sentex.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (alchemy.franken.de [0.0.0.0]); Sat, 30 Jan 2016 18:26:18 +0100 (CET) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2016 17:26:23 -0000 --9Iq5ULCa7nGtWwZS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jan 30, 2016 at 11:47:19AM -0500, Mike Tancsa wrote: > On 1/29/2016 8:23 PM, Marius Strobl wrote: > > On Fri, Jan 29, 2016 at 03:41:57PM -0500, Mike Tancsa wrote: > >> > >> No multi queue. Stock GENERIC kernel with a couple of things removed. > >> hw.em are just the defaults. I will try without TSO > >> > >> % ifconfig em0 > >> em0: flags=8843 metric 0 mtu 1500 > >> > >> options=4209b > >> > > > > Hrm, that's strange, TSO4 should be enabled by default so apparently > > you are already disabling it; what is the behavior if you turn it on? > > Do you use a < Gigabit link? > > Hi Marius, > Thanks for looking. The ifconfig output was after I turned off tso as > Harry suggested to try. Its been 24hrs and I have not seen any resets. > I will wait another 36hrs or so and then turn it back on to see if the > problem comes back. > > this link is 100Mb. Ah, okay, that at least makes sense. Can you please verify that with the attached patch applied, you have a setup that works out of the box? Marius --9Iq5ULCa7nGtWwZS Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="em_tso_gig_only_10.diff" Index: sys/dev/e1000/if_em.c =================================================================== --- sys/dev/e1000/if_em.c (revision 294962) +++ sys/dev/e1000/if_em.c (working copy) @@ -1377,8 +1377,15 @@ em_init_locked(struct adapter *adapter) ifp->if_hwassist = 0; if (ifp->if_capenable & IFCAP_TXCSUM) ifp->if_hwassist |= (CSUM_TCP | CSUM_UDP); - if (ifp->if_capenable & IFCAP_TSO4) - ifp->if_hwassist |= CSUM_TSO; + /* + ** There have proven to be problems with TSO when not + ** at full gigabit speed, so disable the assist automatically + ** when at lower speeds. -jfv + */ + if (ifp->if_capenable & IFCAP_TSO4) { + if (adapter->link_speed == SPEED_1000) + ifp->if_hwassist |= CSUM_TSO; + } /* Configure for OS presence */ em_init_manageability(adapter); --9Iq5ULCa7nGtWwZS--