From owner-svn-src-all@freebsd.org Fri Mar 15 18:01:58 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E22BA1528ABB for ; Fri, 15 Mar 2019 18:01:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 691D1743D4 for ; Fri, 15 Mar 2019 18:01:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x741.google.com with SMTP id u22so6014549qkj.11 for ; Fri, 15 Mar 2019 11:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eCHBr7sZ06T4E5n7PugznPweDM/pVsQIOk1aoLogFP8=; b=HWKZ6p0O8yiwx+tyPA0uf90zEFfVUStkLMbsOBiwewZBP4LBJo/yobAUOappTDB7LO OnmjMSdIY1dlAar52BgyhwU8HKBz2Q81Be3F7vGXXLUHdp0hfGFox2ex0vxse/+oofbJ J++V0ZGAJUB+TWGquAUTbFKEowTZAupkVLD7bcxRi0LRnqohJscH+m7BGOTltIlrg3+V vAodu9XrWV/ntLt+iH2Rh3lU1lK8tRvOa37mngFh0uutJhxjYKUNT5PMChFpv1GGqjP6 Zkt8mBvTQDRMbVdbnha0i2B0cwbyZgxwFyKYnh06gtOy/YrUV/8QrZHCMzdNcEeEJ0JJ lakA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eCHBr7sZ06T4E5n7PugznPweDM/pVsQIOk1aoLogFP8=; b=e1EAvqkgn5MpqwLraLrVXeGX70KDMfK8SQ3+PXWy4rns+A58FHuEWLLGQtGf+WGZKl r/CroudKlAIvhqDhOZzy64/qsbIxpnCvJiOIkSmlOwOTM7QCQtzi4z1WWhImspRC7bhc VS17iHnmPy1IrGB1MopBUAZpmroV/CmLrYVqcOh58cwFsg6BTfLqRihXy6qllbVg86Ke uBfGEur9l6qeFhrF4qB9BbEAYLSmH8/vgGoA/Rodah2DKsBbnZuwt1LMFBuhSU6FEUaL dYZDJcUyDCaavxu4F9KseveLc8VP+bfQZdVFmBBbeY0iXdiNTeFb+ueNa6PClRZn9PLU OycQ== X-Gm-Message-State: APjAAAWMzoRLQrzz7gmTvBQDJrf8IulHcgrQxf/nywVh1wQaPiKfY0zx AKlzjL9q9XR8CiiEi5x2yLQZQmoHHGN4QLQm+8w35Q== X-Google-Smtp-Source: APXvYqyEzeWqGOBQk2LAyQBcpDJMrauPu/lp2wAIPpR1UET9NYasBPbgqK+WvCu4EBQEijVLUWYIBwLnWeb514+s0rs= X-Received: by 2002:a37:a34f:: with SMTP id m76mr3970749qke.245.1552672916863; Fri, 15 Mar 2019 11:01:56 -0700 (PDT) MIME-Version: 1.0 References: <201903151727.x2FHR4ls031294@gndrsh.dnsmgr.net> In-Reply-To: <201903151727.x2FHR4ls031294@gndrsh.dnsmgr.net> From: Warner Losh Date: Fri, 15 Mar 2019 12:01:45 -0600 Message-ID: Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve To: "Rodney W. Grimes" Cc: Chuck Tuffli , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 691D1743D4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 18:01:58 -0000 On Fri, Mar 15, 2019 at 11:27 AM Rodney W. Grimes wrote: > > On Fri, Mar 15, 2019 at 9:56 AM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes < > > > freebsd@gndrsh.dnsmgr.net> > > > > wrote: > > > > > > > > > > Author: chuck > > > > > > Date: Fri Mar 15 02:11:28 2019 > > > > > > New Revision: 345171 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > > > > > > > Log: > > > > > > Fix bhyve PCIe capability emulation > > > > > > > > > > > > PCIe devices starting with version 1.1 must set the Role-Based > > > Error > > > > > > Reporting bit. > > > > > > > > > > > > And while we're in the neighborhood, generalize the code > assigning > > > the > > > > > > device type. > > > > > > > > > > > > Reviewed by: imp, araujo, rgrimes > > > > > > Approved by: imp (mentor) > > > > > > MFC after: 1 week > > > > > > Differential Revision: https://reviews.freebsd.org/D19580 > > > > > > > > > > This code requires maintainer approval before a commit, > > > > > though this was well reviewed that doesnt exclude it > > > > > from the MAINTAINERS entry. > > > > > > > > > > Leave it for now, I am sure jhb or thyco are fine with it, > > > > > this is just a heads up FYI for future commits. > > > > > > > > > > Bhyve code has been and still is under a fairly tight > > > > > MAINTAINER status. > > > > > > > > > > > > > There is no such thing as a hard lock in FreeBSD. This sounds like > you > > > are > > > > advocating for that, but that's not the case. > > > > > > > > Stop this stupid nitpicking for single line commits. We don't have > that > ^^^^^^ > > Thank you for calling my actions stupid, in effect demoralizing me with > the label that includes. I may nit pick, but I never call people degrading > names on a public list. I said your actions (specifically the nitpicking) were stupid. I never called you stupid, and don't think you are stupid. Warner