Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Feb 2016 19:32:12 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Jason Helfman <jgh@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r408737 - head/ports-mgmt/portmaster
Message-ID:  <0A5EBE837A33AF5F79413377@ogg.in.absolight.net>
In-Reply-To: <CAMuy=%2Bj7WuNR5%2B90fmMH7oBX-5BjeDEj0teLrrSC1ip8v9_5Aw@mail.gmail.com>
References:  <201602121546.u1CFk4fB037748@repo.freebsd.org> <CAMuy=%2Bj7WuNR5%2B90fmMH7oBX-5BjeDEj0teLrrSC1ip8v9_5Aw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--==========EA43ADBFF3C892ABDF1A==========
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

+--On 12 f=C3=A9vrier 2016 10:01:48 -0800 Jason Helfman <jgh@FreeBSD.org> =
wrote:
| On Fri, Feb 12, 2016 at 7:46 AM, Mathieu Arnold <mat@freebsd.org> wrote:
|> Author: mat
|> Date: Fri Feb 12 15:46:04 2016
|> New Revision: 408737
|> URL: https://svnweb.freebsd.org/changeset/ports/408737
|>=20
|> Log:
|>   Remove unneeded dependencies on bash and zsh.
|>=20
|>   With hat:     portmgr
|>   Sponsored by: Absolight
|>=20
|> Modified:
|>   head/ports-mgmt/portmaster/Makefile
|>=20
|> Modified: head/ports-mgmt/portmaster/Makefile
|> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
|> =3D=3D=3D=3D=3D=3D --- head/ports-mgmt/portmaster/Makefile Fri Feb 12 =
15:34:10 2016
|> (r408736) +++ head/ports-mgmt/portmaster/Makefile Fri Feb 12 15:46:04
|> 2016        (r408737) @@ -2,6 +2,7 @@
|>=20
|>  PORTNAME=3D      portmaster
|>  PORTVERSION=3D   3.17.9
|> +PORTREVISION=3D  1
|>  CATEGORIES=3D    ports-mgmt
|>  MASTER_SITES=3D  LOCAL/bdrewery/${PORTNAME}/ \
|>                 http://mirror.shatow.net/freebsd/${PORTNAME}/ \
|> @@ -24,9 +25,6 @@ PLIST_FILES=3D  sbin/portmaster \
|>  BASH_PLIST_FILES=3D      etc/bash_completion.d/portmaster.sh
|>  ZSH_PLIST_FILES=3D       share/zsh/site-functions/_portmaster
|>=20
|> -BASH_RUN_DEPENDS=3D      bash>=3D0:${PORTSDIR}/shells/bash
|> -ZSH_RUN_DEPENDS=3D       zsh>=3D0:${PORTSDIR}/shells/zsh
|> -
|>  verify: checksum
|>=20
|=20
| Does this break run dependency if a user chooses option of bash/zsh,
| as helper files will be installed, but
| bash/zsh won't be installed?

The BASH/ZSH options install completions files, having portmaster depend on
bash or zsh is silly, portmaster does not need either to run.  If the user
wants to use bash completions, he's certainly already using bash and has it
installed.

Also, I don't know how exactly zsh works, but for bash, the dependency was
wrong anyway, for it to work, you need the shells/bash-completion port.

--=20
Mathieu Arnold
--==========EA43ADBFF3C892ABDF1A==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQJ8BAEBCgBmBQJWviUuXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I1NkP/Ahj1G7rG6vONixYrppoNSTW
R4abq5se8Zn7VmJbAwWYzTEDrOOV5BfG3czebQz/svLv6ouQ1sYQ7cBBA4/TcupS
VTHpSZZ8moxHTq3RZjtWF41iohiGE00vl74p5AA2QGsHj0oHEFQJ5QpCNWrsX3EY
NS5Ny5Iqok5/zjekq6+EV9xb5zAr0bWbnB/4F7oXx0Iuzt2GXEVX/cfIKOgFtypX
/k6B00PCg0nf0q9fb6YNDnMBGQlG2MANMQCsnxDLwA57t/oGumawgYMY9m1eoD+P
AGe6Q63v+1h3djS4847mrWtCIsL8c05UJc2olqATCgoFyC54KzJ5G/YSKiA1fCE5
qBMdQ38s2Hlblac+Wx0yBWuxesstCAWFveO4UsvUubtty105H2TeTT5rkBRhiSig
A7RJmwjsO4tJxEF1OE8JM2uVuOugdDoSckenNL1qE4/0XS3akrB+pdYIy0RnXEdj
PNskAy7OmJ6Hx18qHZoTqF6BerTQJJTVQEh5u5Wt5jVW72uiyrlP7T0UWmN/exvL
k8pfH9F53u6/8ROrhakpjRnbJxF4hereRhPt9SGZtw8dvPC3JZB6VpSvKGcEj09L
XhwM0293Rb0Q6kq2OWw/sVJ5tduT8U6tt1xxlyl+ZxFpB9btVLZNJjwYZGjVn459
zB8fJfUrLoyqO35EgjTl
=m/sy
-----END PGP SIGNATURE-----

--==========EA43ADBFF3C892ABDF1A==========--




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0A5EBE837A33AF5F79413377>