From owner-svn-src-all@freebsd.org Sat Jul 29 20:11:47 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 503C0DCA280; Sat, 29 Jul 2017 20:11:47 +0000 (UTC) (envelope-from zbodek@gmail.com) Received: from mail-pg0-x22a.google.com (mail-pg0-x22a.google.com [IPv6:2607:f8b0:400e:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 17BCF76AA9; Sat, 29 Jul 2017 20:11:47 +0000 (UTC) (envelope-from zbodek@gmail.com) Received: by mail-pg0-x22a.google.com with SMTP id u185so17723106pgb.1; Sat, 29 Jul 2017 13:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=cLha8ZBeMCZrMf02pYawsOmVk391mp+6z1JubeRmGwc=; b=okMMSjyhcJmKbH3uB6PMNPVCyWQfe9kQwTi57v02Co5InYhiVr0m0PQpUSGWfZJ/P1 mLa/hNLOdmTvlrgekgNeFxrTBsZTlGl2lE8NLrzosbA9V6LDjXT1tJzyjgSLk6REOqWW 3KqO/vcPTW8wLranSrpPPG5sGFxzcJQlFfgCY4+gfZXz+VfnwGr4HbsmlrWabblqEBCV bqKg2DYXF6iwUjvb5GvXmNxB2oEug3metgTjOu4z2kf/w2jikrYZl0QCcUNlwq607YzU w1Snr+Blb3lXJZryiIRQnKmh7h1VNqjxAWmPsf0lWyOqz+ymgCASbwG0LAjkV7y6k1kD SDdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=cLha8ZBeMCZrMf02pYawsOmVk391mp+6z1JubeRmGwc=; b=jmGxDcJWf41SHpKzMJt37r3/bpwlGDBzlX3JJ1PzLzb0QMgzGFNX8RdTm5mkhtqStZ JVD2rz5hsg8cjP+H8s+BS5639y0x8obbN/RSB1McuV8tCKUg54CAiC+5KaQbm4lWc642 yVbn3TJE/OeTtnbww+f+Xr+i35pJFejmv5yMHsTFoUW6ZjbzYCpKVJsFv3PFMvUwRrWc UWx4BAL2kRh6G5xwgaTBrnmlaMqsjUlN4q3f1VV7YYvbTKq6FBsXd9iBpjEzmALmFg/O fjbtsz86FdDxnWBUZuROblPaGAl2fLNujtfavhyqcd+p/Vkke/jogscYJt40uVDrp4VI db8A== X-Gm-Message-State: AIVw112Fy1d8AZlC18MQO0TKgPrm5y3tgyxCy9Yb7UX/vRzPENMeG6Sa 1RXeBa9mZGpmliOuh6ply4xxUcklAyTh7Kw= X-Received: by 10.84.191.165 with SMTP id a34mr11956914pld.243.1501359106532; Sat, 29 Jul 2017 13:11:46 -0700 (PDT) MIME-Version: 1.0 Sender: zbodek@gmail.com Received: by 10.100.157.166 with HTTP; Sat, 29 Jul 2017 13:11:26 -0700 (PDT) In-Reply-To: <1501344365.90400.99.camel@freebsd.org> References: <201707272314.v6RNEHwQ033479@repo.freebsd.org> <1501344365.90400.99.camel@freebsd.org> From: Zbigniew Bodek Date: Sat, 29 Jul 2017 22:11:26 +0200 X-Google-Sender-Auth: vdfSFZD8VJZZ3BbwBKfxaWL74mA Message-ID: Subject: Re: svn commit: r321633 - in head/sys/arm: arm include To: Ian Lepore Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jul 2017 20:11:47 -0000 2017-07-29 18:06 GMT+02:00 Ian Lepore : > On Thu, 2017-07-27 at 23:14 +0000, Zbigniew Bodek wrote: >> Author: zbb >> Date: Thu Jul 27 23:14:17 2017 >> New Revision: 321633 >> URL: https://svnweb.freebsd.org/changeset/base/321633 >> >> Log: >> Fix TEX index acquisition using L2 attributes >> >> The TEX index is selected using (TEX0 C B) bits >> from the L2 descriptor. Use correct index by masking >> and shifting those bits accordingly. >> >> Differential Revision: https://reviews.freebsd.org/D11703 > > How did you guys discover this bug, like what were the symptoms? Hello Ian, We had bug in usage of pmap_remap_vm_attr() and fixing it didn't help for the issue so the second bug has been found here. > Should we consider merging this to 11-stable? As far as I know nobody besides Armada38x is using this function in HEAD and nobody uses it in 11. You may merge it to 11 though (just for the safety of this code in the future). > > -- Ian