Date: Thu, 25 Feb 2021 13:37:59 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566529 - head/x11/foot Message-ID: <7dmw-4920-wny@FreeBSD.org> In-Reply-To: <20210225115005.ebfocnpwupvnjubk@aching.in.mat.cc> (Mathieu Arnold's message of "Thu, 25 Feb 2021 12:50:05 %2B0100") References: <202102251130.11PBUM4M013317@repo.freebsd.org> <20210225115005.ebfocnpwupvnjubk@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Arnold <mat@freebsd.org> writes:
> On Thu, Feb 25, 2021 at 11:30:22AM +0000, Jan Beich wrote:
>
>> +post-patch: terminfo-patch
>> +terminfo-patch:
>> + @${REINPLACE_CMD} '/datadir/s/terminfo/site-&/' ${WRKSRC}/meson.build
>
> This seems overengineered, there is no post-patch target in the
> Makefile, so, why create a new target, and hook it up to a non existing
> target, instead of just using a regular post-patch target?
The whole conditional was self-contained, so if someone added a post-patch
for all FreeBSD releases (e.g., under portmgr blanket) they wouldn't have
to test on -CURRENT separately.
> If there is a good reason for that, it is not obvious, and the reason
> needs to be documented in the Makefile.
I've found another style bug (= vs. +=) and fixed in r566530.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7dmw-4920-wny>