From owner-freebsd-pf@freebsd.org  Thu Oct  6 09:03:47 2016
Return-Path: <owner-freebsd-pf@freebsd.org>
Delivered-To: freebsd-pf@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20034BD3AA9
 for <freebsd-pf@mailman.ysv.freebsd.org>; Thu,  6 Oct 2016 09:03:47 +0000 (UTC)
 (envelope-from kp@FreeBSD.org)
Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits))
 (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E028D78E
 for <freebsd-pf@freebsd.org>; Thu,  6 Oct 2016 09:03:46 +0000 (UTC)
 (envelope-from kp@FreeBSD.org)
Received: from [192.168.228.1] (vega.codepro.be [IPv6:2a01:4f8:162:1127::3])
 (Authenticated sender: kp)
 by venus.codepro.be (Postfix) with ESMTPSA id 22E821567D;
 Thu,  6 Oct 2016 11:03:45 +0200 (CEST)
From: "Kristof Provost" <kp@FreeBSD.org>
To: "Franco Fichtner" <franco@lastsummer.de>
Cc: "Eugene M. Zheganin" <emz@norma.perm.ru>,
 "freebsd-pf@freebsd.org" <freebsd-pf@freebsd.org>
Subject: Re: dscp set/get
Date: Thu, 06 Oct 2016 11:03:45 +0200
Message-ID: <C539471F-8C0C-4BCD-815C-D449EF1427DB@FreeBSD.org>
In-Reply-To: <C1F20DD6-5B32-4856-A2F7-7DAFB38E4D3A@lastsummer.de>
References: <57F5D9D2.1060103@norma.perm.ru>
 <311888F1-3BD6-4C4E-818D-C4A9C00B55ED@FreeBSD.org>
 <C1F20DD6-5B32-4856-A2F7-7DAFB38E4D3A@lastsummer.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed; markup=markdown
Content-Transfer-Encoding: 8bit
X-Mailer: MailMate (2.0BETAr6056)
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
 \(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf/>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2016 09:03:47 -0000

On 6 Oct 2016, at 10:30, Franco Fichtner wrote:
>> On 06 Oct 2016, at 10:10 AM, Kristof Provost <kp@FreeBSD.org> wrote:
>>
>> On 6 Oct 2016, at 6:57, Eugene M. Zheganin wrote:
>>> pf still lacks the DSCP handling, will it be difficult/expensive to 
>>> add
>>> this ? AFAIK ipfw got this recently.
>>>
>> pf has set-tos and tos keywords. What is it not letting you do?
>
> I think it works already with the plain hex/decimal values given,
> though we're missing OpenBSD's parser support for special DSCP
> options with its funky naming:
>
> "This rule applies to packets with the specified TOS bits set. string
> may be one of critical, inetcontrol, lowdelay, netcontrol,throughput,
> reliability, or one of the DiffServ Code Points: ef, af11 ... af43,
> cs0 ... cs7; number may be either a hex or decimal number."
>
> http://man.openbsd.org/OpenBSD-current/man5/pf.conf.5
>
> Looks like pfctl(8) is the only thing to "fix" here.  I'll take a 
> look.
>
Oh, yes, if you want those constants that should be a straightforward 
port of
their changes to parse.y. I have no objections to including that.  
It’s another
(small) step in bringing our pf closer to openbsd pf.

Regards,
Kristof