From owner-svn-src-head@freebsd.org Sat May 19 16:57:28 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9240DEDA4E0; Sat, 19 May 2018 16:57:28 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 04CE4766C3; Sat, 19 May 2018 16:57:27 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w4JGvIYr016606; Sat, 19 May 2018 09:57:18 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w4JGvIdr016605; Sat, 19 May 2018 09:57:18 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201805191657.w4JGvIdr016605@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r333822 - head/sys/kern In-Reply-To: To: Matthew Macy Date: Sat, 19 May 2018 09:57:18 -0700 (PDT) CC: Emmanuel Vadot , owner-src-committers@freebsd.org, rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 16:57:28 -0000 [ Charset UTF-8 unsupported, converting... ] > On Sat, May 19, 2018 at 07:17 Emmanuel Vadot wrote: > > > On 2018-05-19 15:35, Rodney W. Grimes wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > >> Author: mmacy > > >> Date: Sat May 19 02:15:40 2018 > > >> New Revision: 333822 > > >> URL: https://svnweb.freebsd.org/changeset/base/333822 > > >> > > >> Log: > > >> fix gcc8 unused variable and set but not used variable in unix > > >> sockets > > >> add copyright from lock rewrite while here > > >> > > >> Modified: > > >> head/sys/kern/uipc_usrreq.c > > >> > > >> Modified: head/sys/kern/uipc_usrreq.c > > >> > > ============================================================================== > > >> --- head/sys/kern/uipc_usrreq.c Sat May 19 00:47:24 2018 > > (r333821) > > >> +++ head/sys/kern/uipc_usrreq.c Sat May 19 02:15:40 2018 > > (r333822) > > >> @@ -4,7 +4,7 @@ > > >> * Copyright (c) 1982, 1986, 1989, 1991, 1993 > > >> * The Regents of the University of California. > > >> * Copyright (c) 2004-2009 Robert N. M. Watson > > >> - * All rights reserved. > > > > > > Did you have permission from Robert Watson to remove this? This issue seems to be getting ignored? > > >> + * Copyright (c) 2018 Matthew Macy > > >> * > > >> * Redistribution and use in source and binary forms, with or without > > >> * modification, are permitted provided that the following conditions > > > ... > > > > That also seems a small patch to add your name in the copyright. > > > > Uhh... Locking rewrite was a small patch? Really? I agree with Matt, he has done plenty of work to this code to justify his copyright claim. -- Rod Grimes rgrimes@freebsd.org