From owner-freebsd-doc Tue Mar 4 11:25:59 2003 Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CAE437B401 for ; Tue, 4 Mar 2003 11:25:58 -0800 (PST) Received: from perrin.int.nxad.com (internal.ext.nxad.com [69.1.70.251]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AD7143FAF for ; Tue, 4 Mar 2003 11:25:57 -0800 (PST) (envelope-from sean@perrin.int.nxad.com) Received: by perrin.int.nxad.com (Postfix, from userid 1001) id 6998A21079; Tue, 4 Mar 2003 11:25:47 -0800 (PST) Date: Tue, 4 Mar 2003 11:25:47 -0800 From: Sean Chittenden To: Peter Pentchev Cc: freebsd-doc@FreeBSD.org Subject: Re: Update to the handbook (NSFBUFS)... Message-ID: <20030304192547.GG79234@perrin.int.nxad.com> References: <20030304000126.GV79234@perrin.int.nxad.com> <20030304104211.GI518@straylight.oblivion.bg> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4HoONH8zr3Mj5MZN" Content-Disposition: inline In-Reply-To: <20030304104211.GI518@straylight.oblivion.bg> User-Agent: Mutt/1.4i X-PGP-Key: finger seanc@FreeBSD.org X-PGP-Fingerprint: 3849 3760 1AFE 7B17 11A0 83A6 DD99 E31F BC84 B341 X-Web-Homepage: http://sean.chittenden.org/ Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --4HoONH8zr3Mj5MZN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > Howdy. Much to my surprise, there's a lack of documentation on the > > 'sfbufa' state and what it means. Hopefully Google will pick this up > > and it'll make life easier for folks. There's a whitespace patch in > > there as well. > >=20 > > http://people.freebsd.org/~seanc/patches/#handbook_nsfbufs_update > >=20 > > These look alright? -sc >=20 > The whitespace patch looks great. Thx, committed. > For the NSFBUFS one, two comments. First, it may be better to use > 'may' instead of 'will' in the section: if there are > enough sf_buf structures, the sendfile(2) call will not block at > all. Good catch, changed. > Second, since you are rewriting the whole paragraph above (the one > actually explaining what NSFBUFS is all about), it will be perfectly > acceptable to introduce a whitespace change (or fix) there: change > the leading spaces to tabs in all but the first line :) I didn't even check for that, emacs didn't change the spaces to tabs since the 1st indentation was done with spaces and not tabs. Fixed and committed. Thank you for reviewing the patch. -sc --=20 Sean Chittenden --4HoONH8zr3Mj5MZN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Comment: Sean Chittenden iD8DBQE+ZP273ZnjH7yEs0ERAoIeAJ9sgIojyGWhaqGjvCC4lZ1xBRmdeQCcD6Dz tkQlpr9a9MBb+asaTQZLzwU= =gU6f -----END PGP SIGNATURE----- --4HoONH8zr3Mj5MZN-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message