From owner-cvs-all Fri Feb 14 14:15:14 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34D5537B405; Fri, 14 Feb 2003 14:15:11 -0800 (PST) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 96AB443F93; Fri, 14 Feb 2003 14:15:05 -0800 (PST) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.7/8.12.7) with ESMTP id h1EMF3EJ059745; Sat, 15 Feb 2003 01:15:04 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.7/8.12.6/Submit) id h1EMF38Q059744; Sat, 15 Feb 2003 01:15:03 +0300 (MSK) (envelope-from ache) Date: Sat, 15 Feb 2003 01:15:03 +0300 From: "Andrey A. Chernov" To: Juli Mallett Cc: Kirk McKusick , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/newfs mkfs.c src/sys/ufs/ffs ffs_alloc.c ffs_vfsops.c Message-ID: <20030214221503.GA59673@nagual.pp.ru> References: <200302142131.h1ELVwvm057944@repoman.freebsd.org> <20030214153328.A78405@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030214153328.A78405@FreeBSD.org> User-Agent: Mutt/1.5.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Feb 14, 2003 at 15:33:28 -0600, Juli Mallett wrote: > * De: Kirk McKusick [ Data: 2003-02-14 ] > [ Subjecte: cvs commit: src/sbin/newfs mkfs.c src/sys/ufs/ffs ffs_alloc.c ffs_vfsops.c ] > > mckusick 2003/02/14 13:31:58 PST > > > > Modified files: > > sbin/newfs mkfs.c > > sys/ufs/ffs ffs_alloc.c ffs_vfsops.c > > Log: > > Replace use of random() with arc4random() to provide less guessable > > values for the initial inode generation numbers in newfs and for > > newly allocated inode generation numbers in the kernel. > > Are the sequences for it also repeatable in the newfs case for e.g. the > regression tests, where it is used unseeded? Obvious answer - no. BTW, this fix really fixes nothing for FreeBSD case because we already use srandomdev() (for non-regression case). -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message