From nobody Thu Apr 20 09:13:52 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q2BmM2CySz46YYF; Thu, 20 Apr 2023 09:13:55 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q2BmM0L4Hz4BJQ; Thu, 20 Apr 2023 09:13:55 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681982035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LWBm47ZjQiB6qivzt/lBM6o8Z9jYH7xc+YAI0i93T1g=; b=q6EZgxCXth/WjnZYYtpqY67tDhnJtoqO+cCmeuRAaAtISEtk+7UuTVDgVuWehe+6OrT/Ig Djfy7G1A4+semphcWyUYmbMwMCmxV5cjhtzPO1Ts14Xi5AjcAefTQVo1fE38lDqyhGf+MD cnvR0gjF+k17jxzjaBxQSLbx7sYS5z84zuSRw6PvAOw+GgGGkE0WWqhhuBbNmzTaQJXkB/ awxfhI3C1n0WH66gPfpk2Co//lGrePhuAc8yotn6GAF1U1/LnnAfCGOHUZxMfINkyrXSVD PXvOsU0YgRFtG0dqlO5ZWR+1AhYxouAsXKWiczUHem3pfKlhW6HcREjTw5DBHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681982035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LWBm47ZjQiB6qivzt/lBM6o8Z9jYH7xc+YAI0i93T1g=; b=W4AELXSaBK7T9JYsaM+6y/INmGp3tR/+AD7BATFFdaHA6CkMLAgzRzirgoANlC9eryr+Rl mZ8gtJeR/hFAyIkhzo0U6/VdTXtqwQSEoIjPsti5Dye4oJUbYJ2DrPCNH9ZSJCsbN5Zem5 BW5B8qU+o1QTZ+lBVsMK/Sp9PGR26kTM0wO24/V2WcILZQrhOmESxadBxtwvkhsSVqjCiE 6GLrJL/EmyEc89wiUCmrA9mpl+SBU+ou13iC6SKhiGort57Ke0vCaWCzTO6+8yaUdqnJeb wAcwRqwjRD1GYJuxJmfWYCJz3NKxMMLBELFjLVAgO0O7mcRyXlSVWmrRN94+tg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681982035; a=rsa-sha256; cv=none; b=Hu8AwLb97E+JfGLp9oLlebksB1kVm19AlZdik/qUe97O2UopDtpur661uyzomkQ6jx8rZf siRMHS+Ymk2Z7zC8K6/2lCatAna8Nb2brvh0cn5XhhLf9BsSHJzrD4KbRQySjMPjC9SmAw +UlIsj0aIW52QrAN0QCrNVEk5JiwlkcytS4JLOF5W5+ce5dxHyON7VGIFetwj6P1k4U481 HrOvNTwTHMpuh/seS5Z4A5p8P1VmgqixnKgGcplFrbbAHFMJN+GcpFRhlFFP7xMtCkETiL Oa+QY19KqdT4IEiIFTBlP4julQahKqfmjBcaD1Iafpojrlh01EIgFGOGK5/Exg== Received: from localhost (p200300cb8725f568bdce6866266242cd.dip0.t-ipconnect.de [IPv6:2003:cb:8725:f568:bdce:6866:2662:42cd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q2BmL3P6lzfgv; Thu, 20 Apr 2023 09:13:54 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Thu, 20 Apr 2023 11:13:52 +0200 From: Gordon Bergling To: John Baldwin Cc: Alexey Dokuchaev , Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: b12ccd0bb1b3 - main - stand: Remove double words in source code comments Message-ID: References: <202304180515.33I5FKdK006761@gitrepo.freebsd.org> <5B4D966A-896A-4C77-97CD-1594B9C79B42@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: X-Operating-System: FreeBSD 13.2-STABLE amd64 X-Host-Uptime: 11:08AM up 2 days, 21:50, 2 users, load averages: 0.47, 0.52, 0.51 X-ThisMailContainsUnwantedMimeParts: N Hi John, On Tue, Apr 18, 2023 at 10:56:49AM -0700, John Baldwin wrote: > On 4/17/23 11:59 PM, Alexey Dokuchaev wrote: > > On Tue, Apr 18, 2023 at 08:12:51AM +0200, Gordon Bergling wrote: > >> On Tue, Apr 18, 2023 at 06:31:28AM +0100, Jessica Clarke wrote: > >>> On 18 Apr 2023, at 06:15, Gordon Bergling wrote: > >> [...] > >>>> --- a/stand/i386/boot0/Makefile > >>>> +++ b/stand/i386/boot0/Makefile > >>>> @@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?= 0x8f > >>>> # 0xb6 (182d) corresponds to 10 seconds. > >>>> BOOT_BOOT0_TICKS?= 0xb6 > >>>> > >>>> -# The base address that we the boot0 code to to run it. Don't change this > >>>> +# The base address that we the boot0 code to run it. Don't change this > >>> > >>> This was correct and is now incorrect; read as "that we [load] the > >>> boot0 code to in order to run it". > >> > >> I just reverted the change. Sorry, not a native speaker on this side > >> and the sentence was a little hard to understand. > > > > This reminds me of the situation with commit 8ca67bf1273 which jrtc27@ > > pointed out was wrong, so I'd say again that comments like this should > > be rephrased: these consequent double words make it hard to understand > > and just begging for someone to try to "fix" it again in the future. > > Yes, I'll try to reword it. Gordon, your second change here was correct > (the double "value") and you should go ahead and re-do that one. Thanks for the reminder, done in 66095010d1f4. --Gordon