Date: Tue, 27 Jun 2023 11:17:10 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, Sumit Saxena <sumit.saxena@broadcom.com> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor Message-ID: <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> In-Reply-To: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=_MailMate_7EE3E919-6334-4664-B618-2D7388FA5076_= Content-Type: text/plain; format=flowed Content-Transfer-Encoding: quoted-printable On 4 Nov 2022, at 23:55, Warner Losh wrote: > The branch main has been updated by imp: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc7861020= dc3a2a2d717 > > commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 > Author: Sumit Saxena <sumit.saxena@broadcom.com> > AuthorDate: 2022-11-04 22:24:32 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2022-11-04 22:24:32 +0000 > > if_bnxt: Add support for VLAN on Thor > > Reviewed by: imp > Differential Revision: https://reviews.freebsd.org/D36443 > --- > sys/dev/bnxt/bnxt.h | 3 +- > sys/dev/bnxt/bnxt_hwrm.c | 110 = > ++++++++++++++++++++++++++++------------------- > sys/dev/bnxt/bnxt_hwrm.h | 7 ++- > sys/dev/bnxt/if_bnxt.c | 7 ++- > 4 files changed, 74 insertions(+), 53 deletions(-) > This commit appears to have broken vlan on these interfaces. My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a = Dell T640, if that helps). A simple vlan creation on top of one: ifconfig vlan create ifconfig vlan0 vlan 201 vlandev bnxt0 Results in a loss of connectivity. The kernel logs this, which I assume = is related: `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error.` After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I = can create vlan interfaces on top of bnxt0 without losing connectivity. Best regards, Kristof --=_MailMate_7EE3E919-6334-4664-B618-2D7388FA5076_= Content-Type: text/html Content-Transfer-Encoding: quoted-printable <!DOCTYPE html> <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/xhtml; charset=3Dutf-8"= > </head> <body><div style=3D"font-family: sans-serif;"><div class=3D"markdown" sty= le=3D"white-space: normal;"> <p dir=3D"auto">On 4 Nov 2022, at 23:55, Warner Losh wrote:</p> </div><div class=3D"plaintext" style=3D"white-space: normal;"><blockquote= style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136= BCE; color: #136BCE;"><p dir=3D"auto">The branch main has been updated by= imp:</p> <p dir=3D"auto">URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D= 91fcacc355971f74aa26fc7861020dc3a2a2d717">https://cgit.FreeBSD.org/src/co= mmit/?id=3D91fcacc355971f74aa26fc7861020dc3a2a2d717</a></p> <p dir=3D"auto">commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 <br> Author: Sumit Saxena <sumit.saxena@broadcom.com> <br> AuthorDate: 2022-11-04 22:24:32 +0000 <br> Commit: Warner Losh <imp@FreeBSD.org> <br> CommitDate: 2022-11-04 22:24:32 +0000</p> <p dir=3D"auto"> if_bnxt: Add support for VLAN on Thor</p> <p dir=3D"auto"> Reviewed by: imp <br> Differential Revision: <a href=3D"https://reviews.freebsd.org/D36443"= >https://reviews.freebsd.org/D36443</a>; <br> --- <br> sys/dev/bnxt/bnxt.h | 3 +- <br> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++-------------= ------ <br> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- <br> sys/dev/bnxt/if_bnxt.c | 7 ++- <br> 4 files changed, 74 insertions(+), 53 deletions(-)</p> <br></blockquote></div> <div class=3D"markdown" style=3D"white-space: normal;"> <p dir=3D"auto">This commit appears to have broken vlan on these interfac= es.<br> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a = Dell T640, if that helps).</p> <p dir=3D"auto">A simple vlan creation on top of one:<br> ifconfig vlan create<br> ifconfig vlan0 vlan 201 vlandev bnxt0</p> <p dir=3D"auto">Results in a loss of connectivity. The kernel logs this, = which I assume is related:</p> <p dir=3D"auto"><code style=3D"padding: 0 0.25em; background-color: #E4E4= E4;">bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS erro= r.</code></p> <p dir=3D"auto">After reverting this (and 72e9dbb58cad5262190cf2eae47f764= 021072128) I can create vlan interfaces on top of bnxt0 without losing co= nnectivity.</p> <p dir=3D"auto">Best regards,<br> Kristof</p> </div> </div> </body> </html> --=_MailMate_7EE3E919-6334-4664-B618-2D7388FA5076_=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?419530F4-DB8F-46EA-BF45-C130BCF8A3DE>