From owner-freebsd-current Tue Jun 1 3:17:19 1999 Delivered-To: freebsd-current@freebsd.org Received: from axl.noc.iafrica.com (axl.noc.iafrica.com [196.31.1.175]) by hub.freebsd.org (Postfix) with ESMTP id E50961529E; Tue, 1 Jun 1999 03:17:04 -0700 (PDT) (envelope-from sheldonh@axl.noc.iafrica.com) Received: from sheldonh (helo=axl.noc.iafrica.com) by axl.noc.iafrica.com with local-esmtp (Exim 3.00 #1) id 10olbT-000Bcj-00; Tue, 01 Jun 1999 12:17:03 +0200 From: Sheldon Hearn To: grog@freebsd.org Cc: current@freebsd.org Subject: cdevsw changes broke world in vinum Date: Tue, 01 Jun 1999 12:17:03 +0200 Message-ID: <44684.928232223@axl.noc.iafrica.com> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi Greg, It appears as though the recent changes to the cdevsw structure broke world in vinum: " cc -O -pipe -DVINUMDEBUG -g -O -DKERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I/usr/obj/usr/src/sys/modules/vinum -I/usr/obj/usr/src/sys/modules/vinum/@ -I/usr/obj/usr/src/tmp/usr/include -c /usr/src/sys/modules/vinum/../../dev/vinum/vinum.c /usr/src/sys/modules/vinum/../../dev/vinum/vinum.c:55: `nullreset' undeclared here (not in a function) /usr/src/sys/modules/vinum/../../dev/vinum/vinum.c:55: initializer element for `vinum_cdevsw.d_bogoreset' is not constant /usr/src/sys/modules/vinum/../../dev/vinum/vinum.c: In function `vinumattach': /usr/src/sys/modules/vinum/../../dev/vinum/vinum.c:88: warning: implicit declaration of function `cdevsw_add_generic' /usr/src/sys/modules/vinum/../../dev/vinum/vinum.c: In function `vinum_modevent': /usr/src/sys/modules/vinum/../../dev/vinum/vinum.c:239: `cdevsw' undeclared (first use in this function) /usr/src/sys/modules/vinum/../../dev/vinum/vinum.c:239: (Each undeclared identifier is reported only once /usr/src/sys/modules/vinum/../../dev/vinum/vinum.c:239: for each function it appears in.) *** Error code 1 Stop. [...] " The offending line is: cdevsw[CDEV_MAJOR] = NULL; /* no cdevsw any more */ Should that be vinum_cdevsw? Or did I get unlucky and pull sources between commits? Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message