From owner-svn-src-head@FreeBSD.ORG  Sat Oct 27 22:01:39 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 339E3A1A;
 Sat, 27 Oct 2012 22:01:39 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
 by mx1.freebsd.org (Postfix) with ESMTP id 9BCFA8FC18;
 Sat, 27 Oct 2012 22:01:38 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q9RM1bLB019666;
 Sun, 28 Oct 2012 02:01:37 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q9RM1b2K019665;
 Sun, 28 Oct 2012 02:01:37 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Sun, 28 Oct 2012 02:01:37 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andre Oppermann <andre@FreeBSD.org>
Subject: Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf
Message-ID: <20121027220137.GJ70741@FreeBSD.org>
References: <201210262106.q9QL6YgY000943@svn.freebsd.org>
 <508BBE6C.7010409@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <508BBE6C.7010409@freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2012 22:01:39 -0000

On Sat, Oct 27, 2012 at 12:58:52PM +0200, Andre Oppermann wrote:
A> On 26.10.2012 23:06, Gleb Smirnoff wrote:
A> > Author: glebius
A> > Date: Fri Oct 26 21:06:33 2012
A> > New Revision: 242161
A> > URL: http://svn.freebsd.org/changeset/base/242161
A> >
A> > Log:
A> >    o Remove last argument to ip_fragment(), and obtain all needed information
A> >      on checksums directly from mbuf flags. This simplifies code.
A> >    o Clear CSUM_IP from the mbuf in ip_fragment() if we did checksums in
A> >      hardware. Some driver may not announce CSUM_IP in theur if_hwassist,
A> >      although try to do checksums if CSUM_IP set on mbuf. Example is em(4).
A> 
A> I'm not getting your description here?  Why work around a bug in a driver
A> in ip_fragment() when we can fix the bug in the driver?

Well, that was actually bug in the stack and a very special driver that
demonstrates it. I may even agree that driver is incorrect, but the stack was
incorrect, too.

-- 
Totus tuus, Glebius.