From owner-p4-projects@FreeBSD.ORG  Sun Dec 19 18:03:20 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 965391065670; Sun, 19 Dec 2010 18:03:20 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5738A106564A
	for <perforce@FreeBSD.org>; Sun, 19 Dec 2010 18:03:20 +0000 (UTC)
	(envelope-from gpf@FreeBSD.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
	[IPv6:2001:4f8:fff6::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id 44AD98FC08
	for <perforce@FreeBSD.org>; Sun, 19 Dec 2010 18:03:20 +0000 (UTC)
Received: from skunkworks.freebsd.org (localhost [127.0.0.1])
	by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id oBJI3K06083184
	for <perforce@FreeBSD.org>; Sun, 19 Dec 2010 18:03:20 GMT
	(envelope-from gpf@FreeBSD.org)
Received: (from perforce@localhost)
	by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id oBJI3Kps083181
	for perforce@freebsd.org; Sun, 19 Dec 2010 18:03:20 GMT
	(envelope-from gpf@FreeBSD.org)
Date: Sun, 19 Dec 2010 18:03:20 GMT
Message-Id: <201012191803.oBJI3Kps083181@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
	gpf@FreeBSD.org using -f
From: Efstratios Karatzas <gpf@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 187059 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Dec 2010 18:03:20 -0000

http://p4web.freebsd.org/@@187059?ac=10

Change 187059 by gpf@gpf_desktop on 2010/12/19 18:02:50

	bugfix: audit_new() may return NULL and audit_proc_coredump() was 
	lacking a check for that. I was able to trigger a pagefault by 
	shutting down audit but only if I did that within the first few 
	seconds after the system had done booting up. Anyhoo, it's fixed 
	now.

Affected files ...

.. //depot/projects/soc2010/gpf_audit/freebsd/src/sys/security/audit/audit.c#16 edit

Differences ...

==== //depot/projects/soc2010/gpf_audit/freebsd/src/sys/security/audit/audit.c#16 (text) ====

@@ -1153,6 +1153,12 @@
 	 */
 	td->td_pflags |= TDP_AUDITREC;
 	ar = audit_new(AUE_CORE, td);
+	if (ar == NULL) {
+		audit_commit(td->td_ar);
+		td->td_pflags &= ~TDP_AUDITREC;
+		td->td_ar = NULL;
+		return;
+	}
 	if (path != NULL) {
 		pathp = &ar->k_ar->ar_arg_upath1;
 		*pathp = malloc(MAXPATHLEN, M_AUDITPATH, M_WAITOK);