From owner-freebsd-net@FreeBSD.ORG  Wed Mar 17 09:10:13 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 22A9A16A4CE
	for <freebsd-net@freebsd.org>; Wed, 17 Mar 2004 09:10:13 -0800 (PST)
Received: from sccrmhc12.comcast.net (sccrmhc12.comcast.net [204.127.202.56])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D7B8C43D39
	for <freebsd-net@freebsd.org>; Wed, 17 Mar 2004 09:10:12 -0800 (PST)
	(envelope-from julian@elischer.org)
Received: from interjet.elischer.org ([24.7.73.28])
          by comcast.net (sccrmhc12) with ESMTP
          id <2004031717101101200nd2aoe>; Wed, 17 Mar 2004 17:10:11 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id JAA72529;
	Wed, 17 Mar 2004 09:10:10 -0800 (PST)
Date: Wed, 17 Mar 2004 09:10:07 -0800 (PST)
From: Julian Elischer <julian@elischer.org>
To: David Malone <dwmalone@maths.tcd.ie>
In-Reply-To: <200403171152.aa43952@salmon.maths.tcd.ie>
Message-ID: <Pine.BSF.4.21.0403170908380.72230-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-net@freebsd.org
Subject: Re: PPPoE buglet...
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Mar 2004 17:10:13 -0000

The RFC is al that matters (except for
the compatibility code for idiot suppliers that use the wrong
ethertype.)

Is there a 110 or 1001 nearby that I may have read in error in the spec?


On Wed, 17 Mar 2004, David Malone wrote:

> I spent a while trying to get PPPoE going through a Netopia smart
> modem last night. To cut a long story short, the values for
> PTT_RELAY_SID in src/sys/netgraph/ng_pppoe.h are wrong (at least
> when compared with tcpdump, linux and the RFC). We have:
> 
> #if BYTE_ORDER == BIG_ENDIAN
> #define PTT_RELAY_SID   (0x0106)
> #else
> #define PTT_RELAY_SID   (0x0601)
> #endif
> 
> but we should have:
> 
> #if BYTE_ORDER == BIG_ENDIAN
> #define PTT_RELAY_SID   (0x0110)
> #else
> #define PTT_RELAY_SID   (0x1001)
> #endif
> 
> Anyone object to my fixing it? The only thing I can think of that
> it might break would be people using ng_pppoe as a PPPoE relay with
> only ng_pppoe PPPoE clients.
> 
> 	David.
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
>