From owner-svn-src-all@FreeBSD.ORG Fri May 4 17:19:41 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5BB9106564A; Fri, 4 May 2012 17:19:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id B59288FC17; Fri, 4 May 2012 17:19:41 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1D8C4B945; Fri, 4 May 2012 13:19:40 -0400 (EDT) From: John Baldwin To: Hans Petter Selasky Date: Fri, 4 May 2012 13:11:09 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; ) References: <201205041538.q44FclqK010547@svn.freebsd.org> <201205041214.16342.jhb@freebsd.org> <201205041826.19435.hselasky@c2i.net> In-Reply-To: <201205041826.19435.hselasky@c2i.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Message-Id: <201205041311.09237.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 04 May 2012 13:19:40 -0400 (EDT) Cc: "svn-src-stable@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "svn-src-stable-9@freebsd.org" Subject: Re: svn commit: r235007 - stable/9/sys/dev/pci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2012 17:19:42 -0000 On Friday, May 04, 2012 12:26:19 pm Hans Petter Selasky wrote: > On Friday 04 May 2012 18:14:16 John Baldwin wrote: > > On Friday, May 04, 2012 11:38:47 am Hans Petter Selasky wrote: > > > Author: hselasky > > > Date: Fri May 4 15:38:47 2012 > > > New Revision: 235007 > > > URL: http://svn.freebsd.org/changeset/base/235007 > > > > > > Log: > > > MFC r233662, r233677 and r233678: > > > > > > Writing zero to BAR actually does not disable it and > > > it is even harmful as hselasky found out. Historically, > > > this code was originated from (OLDCARD) CardBus driver and later leaked > > > into PCI driver when CardBus was newbus'ified and refactored with PCI > > > driver. However, it is not really necessary even for CardBus. > > > > FYI, I've got one bug report on HEAD where these changes broke a machine's > > ATA controller. > > Have you considered adding code to disable the I/O or memory range instead of > writing 0 to the bar in this case? I have to figure out what the user's bug is first. The patch that "fixed" it was to restore writing 0 to a BAR that failed to allocate during the initial bus scan. -- John Baldwin