From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Mar 7 21:30:04 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 14DDD106566B for ; Fri, 7 Mar 2008 21:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 033798FC20 for ; Fri, 7 Mar 2008 21:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m27LU3xv048935 for ; Fri, 7 Mar 2008 21:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m27LU38O048927; Fri, 7 Mar 2008 21:30:03 GMT (envelope-from gnats) Date: Fri, 7 Mar 2008 21:30:03 GMT Message-Id: <200803072130.m27LU38O048927@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Dmitry Marakasov Cc: Subject: Re: ports/121453: [patch] improve Mk/bsd.sites.mk MASTER_SITE_GOOGLE_CODE variable X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dmitry Marakasov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 21:30:04 -0000 The following reply was made to PR ports/121453; it has been noted by GNATS. From: Dmitry Marakasov To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/121453: [patch] improve Mk/bsd.sites.mk MASTER_SITE_GOOGLE_CODE variable Date: Sat, 8 Mar 2008 00:26:39 +0300 * Edwin Groothuis (edwin@mavetju.org) wrote: > > > > I submitted this as a PR instead of just commited it because it > > > > might cause some controvacy. > > > I will commit this patch in the next week if I don't receibe any > > > negative replies on it. > > Can't MASTER_SITE_SUBDIR be used for that cases? I think using > > MASTER_SITE_SUBDIR for not-actually-a-subdir is a less pain than > > introducing a new variable. > I have looked at it, but I couldn't really find a way to get it > added as the default. > > The current code is: > > MASTER_SITES_GOOGLE_CODE= http://${PORTNAME}.googlecode.com/files > > This one works for 75% of the ports. > > If we would use the following code: > > MASTER_SITES_GOOGLE_CODE= http://%%SUBDIR%%.googlecode.com/files > > we would need to set MASTER_SITE_SUBDIR for all of them. But strictly > speaking, it isn't a real sub-directory to start with. If changed to MASTER_SITES_GOOGLE_CODE= http://${GOOGLENAME}.googlecode... GOOGLENAME should be defined for each port as well (unless defined as GOOGLENAME?= ${PORTNAME} ). Well, on the other hand, if you see `less painful' as `as little ports modified as possible', this GOOGLENAME stuff is OK. My idea is that we'd better have only one variable with meaning `project name on specific multi-project site', which defaults to ${PORTNAME} and may be overridden if needed. As of now, MASTER_SITE_SUBDIR has this meaning in many cases. -- Dmitry A. Marakasov | jabber: amdmi3@jabber.ru amdmi3@amdmi3.ru | http://www.amdmi3.ru