From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jul 16 06:10:25 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A031916A4CE for ; Fri, 16 Jul 2004 06:10:25 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 814B943D6D for ; Fri, 16 Jul 2004 06:10:25 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i6G6AP1g004079 for ; Fri, 16 Jul 2004 06:10:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i6G6APNe004078; Fri, 16 Jul 2004 06:10:25 GMT (envelope-from gnats) Resent-Date: Fri, 16 Jul 2004 06:10:25 GMT Resent-Message-Id: <200407160610.i6G6APNe004078@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A616716A4CE for ; Fri, 16 Jul 2004 06:04:20 +0000 (GMT) Received: from mail.parodius.com (mail.parodius.com [64.62.145.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5309143D46 for ; Fri, 16 Jul 2004 06:04:20 +0000 (GMT) (envelope-from jdc@pentarou.parodius.com) Received: from pentarou.parodius.com (jdc@localhost [127.0.0.1]) by mail.parodius.com (8.12.11/8.12.11) with ESMTP id i6G64KnA091311 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 15 Jul 2004 23:04:20 -0700 (PDT) (envelope-from jdc@pentarou.parodius.com) Received: (from jdc@localhost) by pentarou.parodius.com (8.12.11/8.12.11/Submit) id i6G64KNP091310; Thu, 15 Jul 2004 23:04:20 -0700 (PDT) (envelope-from jdc) Message-Id: <200407160604.i6G64KNP091310@pentarou.parodius.com> Date: Thu, 15 Jul 2004 23:04:20 -0700 (PDT) From: Jeremy Chadwick To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/69139: suphp 0.5.2 no longer builds on 4.x (cannot locate suphp.o object) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jeremy Chadwick List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2004 06:10:25 -0000 >Number: 69139 >Category: ports >Synopsis: suphp 0.5.2 no longer builds on 4.x (cannot locate suphp.o object) >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Fri Jul 16 06:10:25 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 4.10-PRERELEASE i386 >Organization: Parodius Networking >Environment: System: FreeBSD pentarou.parodius.com 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #0: Wed May 5 03:33:17 PDT 2004 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386 >Description: Port does not build on 4.x machines; builds fine on 5.x. This was caused by my removal of USE_GMAKE (it seems 5.x make supports expansion modifiers for targets/objects such as '%.o : %.c' (all *.o files depend on *.c files), while 4.x does not). I fixed this by using a more proper method; specifying the objects in OBJS, basing a translation from SRCS (using the ":/=" assignment modifiers). >How-To-Repeat: Try to build on a 4.x box. >Fix: Apply below patch. This will update suphp/files/patch-src::Makefile.in and will then work on 4.x and 5.x without relying on GNU make. If this patch does not work, please let me know ASAP and I'll include the actual replacement file (suphp/files/patch-src::Makefile.in) itself. diff -ruN suphp.orig/files/patch-src::Makefile.in suphp/files/patch-src::Makefile.in --- suphp.orig/files/patch-src::Makefile.in Mon Aug 25 05:13:36 2003 +++ suphp/files/patch-src::Makefile.in Thu Jul 15 22:56:23 2004 @@ -1,10 +1,35 @@ --- src/Makefile.in.orig Mon Aug 25 11:50:48 2003 -+++ src/Makefile.in Mon Aug 25 11:50:55 2003 -@@ -39,7 +39,6 @@ ++++ src/Makefile.in Thu Jul 15 22:52:13 2004 +@@ -28,11 +28,13 @@ + INCLUDES = -I$(top_srcdir)/src + RM = rm -f + ++SRCS= suphp.c filesystem.c check.c error.c log.c compat.c ++OBJS= ${SRCS:.c=.o} ++ + all: suphp suphp.mod + +-suphp: suphp.o filesystem.o check.o error.o log.o compat.o +- $(CC) $(LDFLAGS) $(DEFS) -o suphp \ +- suphp.o filesystem.o check.o error.o log.o compat.o ++suphp: ${OBJS} ++ $(CC) $(LDFLAGS) $(DEFS) -o suphp ${OBJS} + + suphp.mod: + @if test "$(APXS)" != "/notfound/"; then \ +@@ -49,7 +51,6 @@ fi install: suphp suphp.mod - $(INSTALL_PROGRAM) -d $(DESTDIR)$(sbindir) $(INSTALL_PROGRAM) -m 4755 suphp $(DESTDIR)$(sbindir)/suphp - @$(MAKE) $(MAKEDEFS) -C apache install + @if test "$(APXS)" != "/notfound/"; then \ + if test "$(APACHE_VERSION_2)" = "true"; then \ +@@ -69,6 +70,6 @@ + @$(MAKE) $(MAKEDEFS) -C apache clean + @$(MAKE) $(MAKEDEFS) -C apache2 clean + +-%.o : %.c ++${OBJS}: ${SRCS} + $(CC) -c $(CFLAGS) $(DEFS) $(INCLUDES) -o $@ $< >Release-Note: >Audit-Trail: >Unformatted: