From owner-svn-src-all@FreeBSD.ORG Fri Apr 2 10:23:12 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E84A106564A; Fri, 2 Apr 2010 10:23:12 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 127A18FC18; Fri, 2 Apr 2010 10:23:11 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2CC21.dip.t-dialin.net [217.226.204.33]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 106008442CC; Fri, 2 Apr 2010 12:23:06 +0200 (CEST) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id A631F5043; Fri, 2 Apr 2010 12:23:02 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o32AN2eB026743; Fri, 2 Apr 2010 12:23:02 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Fri, 02 Apr 2010 12:23:02 +0200 Message-ID: <20100402122302.48713ufeslsu6su8@webmail.leidinger.net> Date: Fri, 02 Apr 2010 12:23:02 +0200 From: Alexander Leidinger To: Robert Watson References: <201004020655.o326tWax079882@svn.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 106008442CC.7C645 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.363, required 6, autolearn=disabled, ALL_TRUSTED -1.44, TW_SV 0.08) X-EBL-MailScanner-From: netchild@freebsd.org X-EBL-MailScanner-Watermark: 1270808587.13237@DowE8xAIp/qnQHuGQRykjw X-EBL-Spam-Status: No Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r206082 - in head: . share/man/man7 share/mk sys/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 10:23:12 -0000 Quoting Robert Watson (from Fri, 2 Apr 2010 10:56:22 +0100 (BST)): > > On Fri, 2 Apr 2010, Alexander Leidinger wrote: > >> WITH_CTF can now be specified in src.conf (not recommended, there >> are some problems with static executables), make.conf (would also >> affect ports which do not use GNU make and do not override the >> compile targets) or in the kernel config (via "makeoptions >> WITH_CTF=yes"). >> >> Additional (related) changes: >> - propagate WITH_CTF to module builds >> - do not add -g to the linker flags, it's a noop there anyway >> (at least according to the man page of ld) >> - do not add -g to CFLAGS unconditionally >> we need to have a look if it is really needed (IMO not) or if there >> is a way to add it only when WITH_CTF is used >> >> Note: ctfconvert / ctfmerge lines will not appear in the build output, >> to protect the innocent (those which do not build with WITH_CTF would >> see the shell-test and may think WITH_CTF is used). > > Excellent -- I'm really glad to see this getting sorted out at last. > > I think there's a reasonable argument that we should be compiling > options KDTRACE_HOOKS into GENERIC, and likewise enabling CTF on the > kernel by default in 9.x. Part of the point of DTrace is that it > "just works", and we already compile CDDL modules by default (and > the hooks don't affect the license of the base kernel as far as I'm > aware). Any thoughts on this? I'm in favour of this. You just need to commit 2 lines for GENERIC (and one for NOTES, I think)... Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 BOFH excuse #36: dynamic software linking table corrupted