From owner-svn-src-all@freebsd.org  Wed Apr 20 20:43:06 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 97C03B16437;
 Wed, 20 Apr 2016 20:43:06 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6695012EF;
 Wed, 20 Apr 2016 20:43:06 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u3KKh5Xo081071;
 Wed, 20 Apr 2016 20:43:05 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u3KKh5oQ081069;
 Wed, 20 Apr 2016 20:43:05 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201604202043.u3KKh5oQ081069@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
 ngie@FreeBSD.org using -f
From: Garrett Cooper <ngie@FreeBSD.org>
Date: Wed, 20 Apr 2016 20:43:05 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r298366 - head/contrib/netbsd-tests/lib/libc/sys
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Apr 2016 20:43:06 -0000

Author: ngie
Date: Wed Apr 20 20:43:05 2016
New Revision: 298366
URL: https://svnweb.freebsd.org/changeset/base/298366

Log:
  Fix coverity issues with contrib/netbsd-tests/lib/libc/sys/t_connect.c
  
  - Ensure socket(2) calls succeed
  - Don't leak slist allocated by earlier socket(2) call
  
  MFC after: 2 weeks
  CID: 976773, 1251405
  Reported by: Coverity
  Sponsored by: EMC / Isilon Storage Division

Modified:
  head/contrib/netbsd-tests/lib/libc/sys/t_connect.c

Modified: head/contrib/netbsd-tests/lib/libc/sys/t_connect.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libc/sys/t_connect.c	Wed Apr 20 20:37:58 2016	(r298365)
+++ head/contrib/netbsd-tests/lib/libc/sys/t_connect.c	Wed Apr 20 20:43:05 2016	(r298366)
@@ -56,6 +56,11 @@ ATF_TC_BODY(connect_low_port, tc)
 	slist = socket(AF_INET, SOCK_STREAM, 0);
 	sd = socket(AF_INET, SOCK_STREAM, 0);
 
+#ifdef __FreeBSD__
+	ATF_REQUIRE(sd > 0);
+	ATF_REQUIRE(slist > 0);
+#endif
+
 	/* bind listening socket */
 	memset(&sinlist, 0, sizeof(sinlist));
 	sinlist.sin_family = AF_INET;
@@ -92,6 +97,9 @@ ATF_TC_BODY(connect_low_port, tc)
 	ATF_REQUIRE(ntohs(sin.sin_port) <= IPPORT_RESERVEDMAX);
 
 	close(sd);
+#ifdef __FreeBSD__
+	close(slist);
+#endif
 }
 
 ATF_TP_ADD_TCS(tp)