From owner-svn-src-all@freebsd.org Thu Jul 14 13:56:01 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D0CDB99256; Thu, 14 Jul 2016 13:56:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4833714D3; Thu, 14 Jul 2016 13:56:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pa0-x231.google.com with SMTP id pp5so22277457pac.3; Thu, 14 Jul 2016 06:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=lwBRv9zXXlHVVYjLcpXSlz4OnX+2+r5YaBgpGIW77xE=; b=RJUTg35Fup8JrmGp19mcHVPGyFW6PCRVWukuYlWiGK0iRciM9sHVyRD8q7DpSIdDXc 0IeI2yd8Om9wSLdkDn3AA+sUqsLWJuwBz7UX/XDG03AZk5dw12X3w2n55qsBXg2il+m6 NmjPehMdrPYyl3OZBW2uf4cfla1LRRdj/uJC76vJ1W2VFW2ndbMysvNyvsB3GqZ2kqbY 0pdGGJ6iVLk4Fn61G2h0COsIOXJprcML+Tgu7CCuvjLGkQnXFwoY1sylL+DagK+j3FOD ZEu+Ah8S8eVgkStgzYkBNVlIT2LYIqxvH7Ey5jC9hBjlHNHjMiYZ1xcmA4MGcRcuHx07 TonQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=lwBRv9zXXlHVVYjLcpXSlz4OnX+2+r5YaBgpGIW77xE=; b=X15rpNuDOzzdc+xJa2L9Re6FuZxVjnLJ1qBffetMieJ1162Eu1XUiC1J9iYbLXxcYn mA1g6yawWwMF2MpPRCjPRNokukMPqJMDD4GtxEiCAIpbW+/j9+XyWHYACyLWVMYNna4U g7aA1gv7d3Qq3/EYiArs9kF5jaQ3nbXRVq5RYslPE5KEgRixW0P7wfeBZ3w9ntCnmoC0 Uc4jak1JL221QeG87pXyojT8vTaZV5ktF88G7+Xel+uBOLWS0NmVKk9sNmPJ9n/RSb88 kgGmz6ztc65MmMpjDBoP9ruio/i4YhtVrixSyXxiD3GOfT3jz1OTnqSWKh24TqmH87mT YpFw== X-Gm-Message-State: ALyK8tJI3rO+CFGE37pMY69TNxNqBeLANaDsJR2JrwiL9LRYbXMdR/Fs8RS1ZWzVdx9ZZA== X-Received: by 10.66.126.178 with SMTP id mz18mr23079181pab.15.1468504560523; Thu, 14 Jul 2016 06:56:00 -0700 (PDT) Received: from [192.168.20.9] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id xs12sm5198826pac.7.2016.07.14.06.55.59 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Jul 2016 06:55:59 -0700 (PDT) Subject: Re: svn commit: r302577 - head/sys/dev/drm2 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_A5308244-9F74-4BCE-8078-D3DCDB3D56F1"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Thu, 14 Jul 2016 06:55:58 -0700 Cc: Garrett Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <095A682C-C8C0-4BAF-947C-A74A250EB2F6@gmail.com> References: <201607111701.u6BH189R083052@repo.freebsd.org> To: Robert Watson X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2016 13:56:01 -0000 --Apple-Mail=_A5308244-9F74-4BCE-8078-D3DCDB3D56F1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jul 13, 2016, at 16:56, Ngie Cooper wrote: >=20 > On Wed, Jul 13, 2016 at 4:54 AM, Robert Watson = wrote: >> On Mon, 11 Jul 2016, Garrett Cooper wrote: >>=20 >>> Add missing default case to capable(..) function definition >>>=20 >>> By definition (enum __drm_capabilities), cases other than = CAP_SYS_ADMIN >>> aren't possible. Add in a KASSERT safety belt and return false in >>> !INVARIANTS case if an invalid value is passed in, as it would be a >>> programmer error. >>>=20 >>> This fixes a -Wreturn-type error with gcc 5.3.0. >>>=20 >>> Differential Revision: https://reviews.freebsd.org/D7188 >>> MFC after: 1 week >>> Reported by: devel/amd64-gcc (5.3.0) >>> Reviewed by: dumbbell >>> Sponsored by: EMC / Isilon Storage Division >>=20 >> Per my comment in the review, I think a panic() here would be = preferable to >> a KASSERT(), as it would come without perceptible runtime cost, and = failstop >> the system if we were violating a design-time security invariant. >=20 > Good point. I'll commit the change tonight. Fixed in r302841. Thanks! --Apple-Mail=_A5308244-9F74-4BCE-8078-D3DCDB3D56F1 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXh5nuAAoJEPWDqSZpMIYVYSgP/12rl0/lQBR6m4+rWiOnAwTF ilYY7fsjP3t1BoHaEHbdfed1OeO7dLajLRxlMO1KHkjZVhPFi+Eu3P/JOG6hU5Qd vNCHEHva2g/EBAUXCLAG2jMW1fW5IUfKxn6sfTAyeFs/+WM/DwnQfdU4OaZ4r5VL PPkvBG+X1l634vm61640OtVBCldB+8nGXMuEvhPbJvMClpI0hVZHv/rZAlYXi3yG +XDxWlCJWsztERHZb5LaGezYlwaUOFSDIRXebq88EdwdYpOTRdR65UUX4ir6BL1G phzOadilojBgN/vkzvCnSHwsDRhlLhrU4PR0gUx9MCHi2rqXnoeYgYGuyv+iN6ZP PkDJ8F+C2smEVMdBK2SQASTKicX+vte5ruxBSQEnDumbnNad4/Y+/g0C5l7gxBmm en3GN4lAYGKDnvL5H0UpP7zgecElnHaMYCwtc0XsiW1r1a6yoBmsRNRyJhazUDia YvB5FdlySqFMSLGAh84+4AKTD8czfybZOKBQb4UdCxkgdToz/vMgiGRNn4DjF+H7 EWLLYgq6VeubMW6zGWtMU5cAW90PhscUAgrWIGftZyVKnsWj3kfk5Oc2qXGJqeUz XXShIrvv7V9Lu1EIk+382sqNamO9cPnuruLPz8m/ZyMiGTvytNlL/y7atZiimTUu W9yINceOT9W/yqkge2La =V5NS -----END PGP SIGNATURE----- --Apple-Mail=_A5308244-9F74-4BCE-8078-D3DCDB3D56F1--