From owner-freebsd-mips@freebsd.org Thu May 26 05:00:20 2016 Return-Path: Delivered-To: freebsd-mips@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 153EBB4A90F; Thu, 26 May 2016 05:00:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x22b.google.com (mail-ig0-x22b.google.com [IPv6:2607:f8b0:4001:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CFE381E08; Thu, 26 May 2016 05:00:19 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-ig0-x22b.google.com with SMTP id fh2so41277411igd.1; Wed, 25 May 2016 22:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=9jKyhjRzIZLEnrjwIPEXj/hV5DG7ioD+9OFJq84/DXU=; b=EbkwN6+sxo4S5rIbGgR2aMoby+hoHy1BQPwqiu4gYM5Pkd6K1AKgkXDJWCruG/0/2p U78ZNKvZ1yYHlPw7BRkzWmuspH9r8kee5Wy6hQg3e1QHh9KsJq0SfVBZc6uwUTA6oSFM UzLRj8rG9tStGS0B0tLDFwwgY/XdGMQoBf9sDpYyhDWyNn13GHWQtfDuG/us6UulNLaC a6PQo4UT0zcFeceZgzR5RkOymrInfAPNcFDNY3zYbOiawmDKMb8/qq8/ANW8m+nDpiXe dD3y9hXI3roahZumuuJgs2TbjTmdPCJsit48C8OIp9oxlfGFlxwSpE08MXy+cwaizllQ KPlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=9jKyhjRzIZLEnrjwIPEXj/hV5DG7ioD+9OFJq84/DXU=; b=G+iYXFgam4rImKKWgdTrvZpHyVG05aNCvczx72dbLrcjd8F2Aq/9kovB7gt6mha3XC /lEDZywsC5GwgyKWluxJ44EVxg/5c3vfhxhGRXMJM2ixt++p6APy4SdbWsbgaqlMYqMa dh92/1XZiMk0IyX1tyYYZWXL5dplNICsmM33XijTQlBd3Sxx+JC3oxoASA5ecUuI43NT cm7rmVdo+w7hKFwg1kkdLyKmRsMMD99vslB21zWCkUBnxQOfMQAFK+Y4IEDdTF6T0t6p hGUf/JsH37GtScGU+uL5VIbMtojJ0JN2oXz7AnY2LtVTA6HXWwqCzJrXr3zxReEo+xU1 2w5g== X-Gm-Message-State: ALyK8tKuflW6kTojHfrq5KMjXZHH5snYKxQtSfPKNGU4o4NhKmXzJ8Zcrtep90bArlQitWOIhRJA5GuFFR+Z8Q== MIME-Version: 1.0 X-Received: by 10.50.3.73 with SMTP id a9mr1419158iga.22.1464238819161; Wed, 25 May 2016 22:00:19 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.113.3 with HTTP; Wed, 25 May 2016 22:00:19 -0700 (PDT) In-Reply-To: References: <201604191539.u3JFdkHx048678@repo.freebsd.org> <20160419171243.GA30453@bsdpad.com> <1461097280.1232.34.camel@freebsd.org> Date: Wed, 25 May 2016 22:00:19 -0700 X-Google-Sender-Auth: wegTJORiBQ75UOtpK8XmGD2vGtg Message-ID: Subject: Re: svn commit: r298274 - head/sys/dev/spibus From: Adrian Chadd To: Patrick Kelsey Cc: "freebsd-mips@freebsd.org" , "freebsd-arm@freebsd.org" , Ruslan Bukin Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 05:00:20 -0000 On 25 May 2016 at 18:57, Patrick Kelsey wrote: > > On Fri, May 20, 2016 at 2:35 AM, Adrian Chadd wrote: >> >> I've reviewed the patches from luiz, and these look fine. but indeed, >> this patchset does set/release the bus each transaction so we can do >> multiple transactions whilst holding the bus. >> >> Which is fine, but it means I have to undo ruslan's removal in the below >> commit. >> >> I'm happy to run through and do each of the spi bus drivers (as there >> are more now than the two you patched) but it's a bit close to the >> 11.0-release cycle to go and churn the spibus code. >> >> But, if people think it's worth doing it so we can try to get mmcspi >> into the tree before 11.0-rel is cut, I'm happy to run through and do >> it. I actually have some AR9331 stuff now that could use mmcspi. :) >> >> What do people think? >> > > Thanks, Adrian. My opinion is that the changes to the spi bus interface and > the corresponding changes to the spi bus drivers you are talking about are > very straightforward and low risk. There is non-zero other interest out > there in using the mmcspi driver, based on the couple of emails I've > received seeking help on the subject in the last six months or so, so I > don't think this would be just a commit for the sake of getting some > interesting new code in. loos and i are thinking about it. I may start landing some of the spibus changes tonight just to lay the foundation. -adrian