From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Mar 2 11:13:01 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1A3F9EB9 for ; Mon, 2 Mar 2015 11:13:01 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DA82936E for ; Mon, 2 Mar 2015 11:13:00 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t22BD0Mr053721 for ; Mon, 2 Mar 2015 11:13:00 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 196796] [NEW PORT] sysutils/librolegen: Library to generate WebOS system bus role files Date: Mon, 02 Mar 2015 11:13:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc short_desc keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2015 11:13:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196796 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC|penzin.dev@gmail.com | Summary|New port: |[NEW PORT] |sysutils/librolegen |sysutils/librolegen: |Library to generate WebOS |Library to generate WebOS |system bus role files |system bus role files Keywords| |needs-qa, patch --- Comment #2 from Kubilay Kocak --- Hi Petr, Upon initial review, I can see at least the following needs fixing: - GH_PROJECT=librolegen is unnecessary, as GH_PROJECT defaults to ${PORTNAME} which is librolegen in this case. - COMMENT should not start with PORTNAME (portlint(8) will tell you this) - INSTALL_TARGET defaults to 'install' as its value, not needed (iirc). - Use BUILD_DEPENDS earlier, and using = rather than += the first time you use it (again portlint(8) will help you here) I would also highly recommend the following QA logs as attachments: - portlint -AC output (you can find it in ports-mgmt/portlint - poudriere testport / bulk -t output. See: [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing-poudriere.html -- You are receiving this mail because: You are the assignee for the bug.