From owner-cvs-src@FreeBSD.ORG Tue Mar 20 16:19:11 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8025B16A400; Tue, 20 Mar 2007 16:19:11 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.freebsd.org (Postfix) with ESMTP id 33C9313C458; Tue, 20 Mar 2007 16:19:04 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.6/8.13.6) with ESMTP id l2KGItZf081293; Tue, 20 Mar 2007 12:18:56 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Bruce Evans Date: Tue, 20 Mar 2007 12:18:51 -0400 User-Agent: KMail/1.6.2 References: <200703192317.l2JNHd59062213@repoman.freebsd.org> <20070320111650.C6064@besplex.bde.org> In-Reply-To: <20070320111650.C6064@besplex.bde.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200703201218.52887.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV 0.88.6/2880/Tue Mar 20 01:04:21 2007 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/mii brgphy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2007 16:19:11 -0000 On Monday 19 March 2007 08:21 pm, Bruce Evans wrote: > On Mon, 19 Mar 2007, Jung-uk Kim wrote: > > jkim 2007-03-19 23:17:39 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/mii brgphy.c > > Log: > > Revert couple of changes from 1.51 and 1.52. Reading link > > status with BMSR is okay for most of the chipsets but BCM5701 PHY > > does not seem to like it. Set media to IFM_NONE if link is not up > > instead of the previous value. > > > > Reported by: Goran Lowkrantz (goran dot lowkrantz at ismobile > > dot com) > > > > Revision Changes Path > > 1.66 +12 -14 src/sys/dev/mii/brgphy.c > > Does this fix the problem that reading the link status causes input > errors? oleg@ has a large patch which avoids this problem by not > always reading the link status in bge_tick(). I use a simpler > verion of this. No, it doesn't. Jung-uk Kim