From owner-svn-src-all@freebsd.org Fri Apr 14 19:59:02 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 237F2D3E857; Fri, 14 Apr 2017 19:59:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7FDBC28; Fri, 14 Apr 2017 19:59:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id i5so16380000pfc.3; Fri, 14 Apr 2017 12:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=2dUsuqeUfLqT86ns1MJ7HYUh3LQxnufSMaWUgtXhgGk=; b=dCiPZKvHSpEJNNnovdIeEUJ8n8ThPr/EUp7pHiZz3/6EdEY00F8kB8j6QJwXKM+cGb LSpscht182mVhEi5eRXuvjM+VOfxPm9ti1wXTlmGwpS5GWhJZElHy6TZ+ZMX49T54E9J 5n0G9AfKamGuI8WSaAmxahbgSEXdgnb+7dMTlh34yR/R3nJ/fphSOIusY4aNglncKDMM lxxHhZmD+T/a1TU+xqZO5zvcFCjGWQhGd1HxKLFXB38xYN5YFk6UGSakA+dRBWFnJY9U BaQT0b7hE/PvZmXoymCGssDke3RjKxxA7D4mgY+VHsmZlGtxFjR+v1ovlFlyrzAxGVKw CEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=2dUsuqeUfLqT86ns1MJ7HYUh3LQxnufSMaWUgtXhgGk=; b=XsSnWLsN2zDHOnjRG+9HFwXk/iupbnLv4SQ2QkLffVbpgVBCCr/vrv3B+Qumri6ViU mLGkiupcC5kZ8wb+zcfdGXtwl0iebNJ9FiMC/3qBaao4RxGkn35mDgzAXel+QCDNUEbK PW1C0MR2Pw4HsuuXmmivMWoow7/8JE2TFYU8Gg2UAmVMseB3ZAQHNVJPjiaO3+YMjNEg T+vTvYv3MnfRN9vgj0PkvCanbyu2Nhmbal3PczqTxpRWGN/xdVqoWOZC3KH1tDDTrqRM PEhL+3N8M22bFO3yfDx5czn/omOXVG6e1shOFfHXoaHajD61cHLQbVC1HrR6XVVkPgvr 3gMw== X-Gm-Message-State: AN3rC/5NBfhIwqTTraKArBOQIxVXrXf9IF1mbnZ4fCxwh+4cNHs+RO40 Z6n5j1pE3EtyRzqxSeA= X-Received: by 10.99.253.5 with SMTP id d5mr8566739pgh.47.1492199941167; Fri, 14 Apr 2017 12:59:01 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id u22sm4697072pgo.67.2017.04.14.12.59.00 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Apr 2017 12:59:00 -0700 (PDT) Subject: Re: svn commit: r316938 - head/sbin/savecore Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_69D9A5FD-DCAF-404A-BB19-ACFAB5E1FD7B"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Fri, 14 Apr 2017 12:58:59 -0700 Cc: Ngie Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <499FA6FF-E691-4941-B96C-3806072D14AA@gmail.com> References: <201704141941.v3EJfmCW003347@repo.freebsd.org> To: Alan Somers X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 19:59:02 -0000 --Apple-Mail=_69D9A5FD-DCAF-404A-BB19-ACFAB5E1FD7B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 14, 2017, at 12:49, Alan Somers wrote: >=20 > On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: >> Author: ngie >> Date: Fri Apr 14 19:41:48 2017 >> New Revision: 316938 >> URL: https://svnweb.freebsd.org/changeset/base/316938 >>=20 >> Log: >> savecore: fix space calculation with respect to `minfree` in = check_space(..) >>=20 >> - Use strtoll(3) instead of atoi(3), because atoi(3) limits the >> representable data to INT_MAX. Check the values received from >> strtoll(3), trimming trailing whitespace off the end to maintain >> POLA. >> - Use `KiB` instead of `kB` when describing free space, total space, >> etc. I am now fully aware of `KiB` being the IEC standard for 1024 >> bytes and `kB` being the IEC standard for 1000 bytes. >> - Store available number of KiB in `available` so it can be more >> easily queried and compared to ensure that there are enough KiB to >> store the dump image on disk. >> - Print out the reserved space on disk, per `minfree`, so end-users >> can troubleshoot why check_space(..) is reporting that there isn't >> enough free space. >>=20 >> MFC after: 7 weeks >> Reviewed by: Anton Rang (earlier diff), cem (earlier = diff) >> Tested with: positive/negative cases (see review); make tinderbox >> Sponsored by: Dell EMC Isilon >> Differential Revision: D10379 >=20 > The free space calculation is still uselessly conservative, because it > doesn't account for the fact that core dumps will always be either > spare or compressed. The result is that savecore will frequently > refuse to save corefiles even when there's plenty of space. I > proposed removing the space check altogether in > https://reviews.freebsd.org/D2587. However, I agreed to wait until > after the compressed core dump feature was merged, because then mostly > accurate space checks will be possible. AFAIK the compressed core > dump feature still hasn't been finished. That CR concerns me. The whole being able to check how much space we have on disk before = dumping is a wonderful tool because it prevents users from having = /var/crash be full of truncated full dumps, text dumps, and/or mini = dumps. The real problem that you=E2=80=99re bringing up is that the size being = passed in to check_size(..) is wrong. It needs to be the on-disk size = (which can be a pessimization from gzip/zlib), not the in-memory size of = all of the dumped pages. Thanks for the note =E2=80=94 this helps me with another related issue = at $work that will likely prevent me from being able to write proper = tests to test out panic dumps on OneFS :). Cheers! -Ngie --Apple-Mail=_69D9A5FD-DCAF-404A-BB19-ACFAB5E1FD7B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8SoDAAoJEPWDqSZpMIYV7voQAKbufDeLzoHSyypP7EJKI49d 3s+0YWJUpPNC6JSxxzMF5CBEJvdPYrjXlPsLiswrwjxwN9DhH3MipoO+KKwvH6q0 XU91WgtlgKoEb93DN7/SE1NeEDBwBT/v/iQYlay+jEQT8Oc7gZJk+FuVuuJBec6d Fx+r1tq7JYSUHUEHVyMBJj9v3n9CjGxm0Cf7g9bWICwJZto9gbwMxMsVeB9Wl37w i2l83PNRGbUy5fduu+xwYgDRfGV/1tA88zwT+bl87mX1TEMkExAO3ZVTbVgVktkc /hS6x/Ao1+l5EcbI/7sDJ20yW8hVv/XCkO+ysOCJNbWCb355BiQXypvFi/oCOTEl CO3+YOadHsPEArC5dbsczI+lTcH/e8pY0d+EteoN7b4UiOQkIn6+ZjfC7Zih36ZM kcvPG367Wdzjhcb5YJSqQEZ3nNHM5pVeHWnIr6Vc/ul1ECYNq/aRLPG1DGd+fhGa x3zVPhCj1ouq5Tb/lNbsAjCh5sOThRC6172Sn3V8vln673mr2ZNl/z+T8lmv6RHo FjYh7gQS3oorcrsPINBakEf9I8rzWVD7Xj4mMdfbUgS09rRyzVN53HDWGfUbWKzB z0LwE46P0IvofiYl+b8Q3FiZscag3MSn5dRadFeFe/F9DQG+mwG9jtjl/FL1o6XV AVe62xAQbTWB01VUPAbE =r1XN -----END PGP SIGNATURE----- --Apple-Mail=_69D9A5FD-DCAF-404A-BB19-ACFAB5E1FD7B--