From owner-svn-src-all@freebsd.org Sat Sep 26 22:28:37 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D800A09145; Sat, 26 Sep 2015 22:28:37 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com [IPv6:2607:f8b0:400e:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1F8A81588; Sat, 26 Sep 2015 22:28:37 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by padhy16 with SMTP id hy16so138094925pad.1; Sat, 26 Sep 2015 15:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1xjWlbcEwHGll7aXe1K4jV9iH4VjYDsG2pNHBYsXcDA=; b=m/hCAxjAAjIjyvVyxU18/n99O0kR1Mei42Y88j8vcxCkX2HzmbIqhCnn0wVIi1Sch8 5OcBR7bIcemMkQnmhG/5cL1I30cjGxWPHWV7fJQnk/BCrWaUX3cg8D9NYqQwzD9fRoZH WddOnqiGV2iOcy0LRQtK4+5ZJV5CWe5F8KdL4nlFItMcsD9V6CB2mRKKcnhWbwKtaBzt PZiTujU+ToiJC3dYKyWA/a/UUPoRdSi1+vEXMCUFo8anYhXgJ+hlcqOpRzhyqs9UYVv6 cPtl4bd9hwq7vP41Bi1jlLAnC/qc50dSyVNVKlawuq2YaWFQrywvx3ng9CSEGxcJnhuO GB0A== X-Received: by 10.68.94.99 with SMTP id db3mr16728722pbb.165.1443306516425; Sat, 26 Sep 2015 15:28:36 -0700 (PDT) Received: from ?IPv6:2601:601:800:126d:8124:8ddf:cc08:d067? ([2601:601:800:126d:8124:8ddf:cc08:d067]) by smtp.gmail.com with ESMTPSA id tz1sm10962199pbc.50.2015.09.26.15.28.35 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 26 Sep 2015 15:28:35 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r288280 - head/sys/kern From: NGie Cooper In-Reply-To: <201509262226.t8QMQuHh018926@repo.freebsd.org> Date: Sat, 26 Sep 2015 15:28:34 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201509262226.t8QMQuHh018926@repo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2015 22:28:37 -0000 > On Sep 26, 2015, at 15:26, Mark Johnston wrote: >=20 > Author: markj > Date: Sat Sep 26 22:26:55 2015 > New Revision: 288280 > URL: https://svnweb.freebsd.org/changeset/base/288280 >=20 > Log: > Remove a check for a condition that is always false by a preceding = KASSERT > that was added in r144704. >=20 > Modified: > head/sys/kern/vfs_subr.c >=20 > Modified: head/sys/kern/vfs_subr.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/kern/vfs_subr.c Sat Sep 26 22:20:30 2015 = (r288279) > +++ head/sys/kern/vfs_subr.c Sat Sep 26 22:26:55 2015 = (r288280) > @@ -1429,11 +1429,6 @@ flushbuflist(struct bufv *bufv, int flag > KASSERT(bp->b_bufobj =3D=3D bo, > ("bp %p wrong b_bufobj %p should be %p", > bp, bp->b_bufobj, bo)); > - if (bp->b_bufobj !=3D bo) { /* XXX: necessary ? */ > - BUF_UNLOCK(bp); > - BO_LOCK(bo); > - return (EAGAIN); > - } > /* > * XXX Since there are no node locks for NFS, I > * believe there is a slight chance that a delayed >=20 Except the KASSERT gets optimized out with !INVARIANTS. Is this = if-statement protecting against bad behavior?=