From owner-freebsd-arm@FreeBSD.ORG Mon Dec 16 00:27:41 2013 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B47C3CD3 for ; Mon, 16 Dec 2013 00:27:41 +0000 (UTC) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 83362101E for ; Mon, 16 Dec 2013 00:27:41 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id un15so4781761pbc.27 for ; Sun, 15 Dec 2013 16:27:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=ciXsvM2bK/MIR+hFqTJJgBKXmojFS+RIsUvbxxpmTng=; b=h41Wsr3XlZqwyBWKpCMRIbu5BjrVjV+smQgLcNipAE81/BNPWJ5UOkCw7oeLtFsfCd qEnjLkQ3oxF+mruA4eLp2mO/RjZbmvC9DgzNBnNusprjNcxiKZrsIhAjyStYKYnrasVP WSHbfBDqU65c751Extxeqjl+VgecNPbtD2HFGY5IMd7E+OWmwkTk3t1bmfhEArZE/z+X gvVaoUKEIniRR705+Oq41Qkp/OKGZCoADDR5U0w+T/0AWYH1lQ0j8wCEJgU4IafqHEnQ bzJSQ30HAcqfXbiDqo2oX9DEpXf2iM5L555did4Gz1z9NEu51FPhiA2BckXaELqCcyWG ZHxw== X-Gm-Message-State: ALoCoQl5WAPTIgsGBXvoMXwI+ADTmSLNa+LBhW4hrJb+zwpchGUTs0v1l8CMV24kOB4N73TWvmxX X-Received: by 10.66.8.66 with SMTP id p2mr16700912paa.129.1387153655163; Sun, 15 Dec 2013 16:27:35 -0800 (PST) Received: from fusion-mac.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id yg3sm29898302pab.16.2013.12.15.16.27.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 15 Dec 2013 16:27:34 -0800 (PST) Sender: Warner Losh Subject: Re: [PATCH] Add stack unwind support for the functions in .ko Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Sun, 15 Dec 2013 17:27:31 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20131215173042.0dead636@bender.Home> To: Howard Su X-Mailer: Apple Mail (2.1085) Cc: freebsd-arm X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2013 00:27:41 -0000 On Dec 15, 2013, at 4:56 PM, Howard Su wrote: > On Monday, December 16, 2013, Andrew Turner wrote: >=20 >> On Mon, 9 Dec 2013 22:44:14 +0800 >> Howard Su > wrote: >>=20 >>> Here is a new version which solve the unreadable $a problem. (the = fix >>> is in ddb/db_main.c in the end of the patch.) >>>=20 >>> I attached the diff for review. >>=20 >> I can't comment on the MD parts of the code, but the ARM change looks >> good. My only request is to add a kernel option to turn on printing = the >> registers in the stack trace as it has been useful for tracking down >> bugs. >>=20 > I read the MD code of MIPS. seems it faces the same situation like arm > (register pass parameter). I will follow its pattern to print out = register. > better than an option? I thought MIPS printed the args from those registers as args and ARM was = the odd man out... Warner