From owner-freebsd-ports-bugs@FreeBSD.ORG  Sun Sep  5 22:30:17 2010
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E4C9E10656A3
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sun,  5 Sep 2010 22:30:17 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B9E698FC12
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sun,  5 Sep 2010 22:30:17 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o85MUHcT090854
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sun, 5 Sep 2010 22:30:17 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o85MUHaI090846;
	Sun, 5 Sep 2010 22:30:17 GMT (envelope-from gnats)
Date: Sun, 5 Sep 2010 22:30:17 GMT
Message-Id: <201009052230.o85MUHaI090846@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Alex Samorukov <samm@os2.kiev.ua>
Cc: 
Subject: Re: ports/150235: sysutils/smartmontools build system bug
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Alex Samorukov <samm@os2.kiev.ua>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Sep 2010 22:30:18 -0000

The following reply was made to PR ports/150235; it has been noted by GNATS.

From: Alex Samorukov <samm@os2.kiev.ua>
To: Doug Barton <dougb@FreeBSD.org>, 
 Garrett Wollman <wollman@FreeBSD.org>,
 bug-followup@FreeBSD.org, developers@FreeBSD.org
Cc:  
Subject: Re: ports/150235: sysutils/smartmontools build system bug
Date: Mon, 06 Sep 2010 00:26:56 +0200

 >
 >> It is not the case. cciss.cpp from the sources uses dev/ciss/cissio.h to
 >> work with cciss devices on FreeBSD. configure script checks if this file
 >> is exists on the compile time, and if its not - does not compile cciss
 >> support in the smartmontools.
 >> If user will try to use cciss driver in this case - smartmontools will
 >> display an error:
 >>
 >> "CCISS support is not available in this build of smartmontools,\n"
 >> "/usr/src/sys/dev/ciss/cissio.h was not available at build time.\n\n");
 >>      
 > If that interface is public (which it seems to be, from glancing at the file),
 > the header should be installed in /usr/include/sys.  There are precedents for
 > this, see<sys/aac_ioctl.h>  and<sys/digiio.h>  (and presumably others).
 >
 > Any reason not to follow Garrett's suggestion to work with a src developer,
 > perhaps one of the ones listed in the header file you need, to have it put
 > somewhere public?
 >    
 
 Just to remind - Garrett's suggestion was to exclude /usr/src/sys from 
 the includes and break ciss functionality completely this way ;-)
 
 Of course i have nothing against cissio.h in the /usr/include/sys and i 
 will try to contact author right now. But before this happens (and also 
 before it will be in all supported freebsd versions) i`m also against 
 removing srv includes from the sources, because it will break ciss 
 functionality only because one person had outdated src tree.
 >   - Philip
 >
 >