From owner-freebsd-net@freebsd.org Tue Aug 4 23:15:36 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E1179B3976 for ; Tue, 4 Aug 2015 23:15:36 +0000 (UTC) (envelope-from barney_cordoba@yahoo.com) Received: from nm3-vm6.bullet.mail.ne1.yahoo.com (nm3-vm6.bullet.mail.ne1.yahoo.com [98.138.91.96]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DF3851515 for ; Tue, 4 Aug 2015 23:15:35 +0000 (UTC) (envelope-from barney_cordoba@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1438730128; bh=HVkMVBd+1wIQSfGtfWgx8Tx1EUhrEZ2pewykDKZuOA8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=P4Xh9EVepR0SsEMe367LMSVQDJM5Bdpxv4Mpb7yigFDXosULpQ1Ghgd5E6DLLrIn83JxO7jiLtEhXoIJmuLH8GGZIAIYzkBdU+ayiRplVR3uKw5SpBTeIS/i9dXy1Zfk+KrFDXDKZt2SDXlrRN2DB5hb0+gMetyV8CLnSH2MD3HYn6oddJE6+rWQiwb3oikiRuGk/Lp2PDyJ2smHl57js6b9+z9y7eguyacJz+Da3uy81m/FjgKrvHHa3S3olkjb0K5pauJv3MxJVCSHY1OSc7MBvmWtXjFY6taGjC+jHTyRai2VURipSO+v2K5qLGqxYXBElfOAha2Vo1/0p9wnWA== Received: from [98.138.100.102] by nm3.bullet.mail.ne1.yahoo.com with NNFMP; 04 Aug 2015 23:15:28 -0000 Received: from [98.138.89.232] by tm101.bullet.mail.ne1.yahoo.com with NNFMP; 04 Aug 2015 23:15:28 -0000 Received: from [127.0.0.1] by omp1047.mail.ne1.yahoo.com with NNFMP; 04 Aug 2015 23:15:28 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 722408.93154.bm@omp1047.mail.ne1.yahoo.com X-YMail-OSG: 7CalNiAVM1n7Bd7W5iSpt7bW8NJxHxnL9f8sFlJCoQ8GRuW2sJIUk5O_gsKBGrv CMCPzioNjMqjJIj175LMy1Wxq8ULbR4UZL37I8GO6QoISSpUMb4uO3fbTsi8diCba5dZ.rTxbn7m Nof.fMo9MUCMUr9P2VO1k5.2zTVDLIhdIVHJ__keF22WPTdCTgApAfYNwK0Mo5y_LlIYOxriUepz q2p2Z1PTmPm_aS7vtXX0PWE6GGQhlgWOQltUnbmGn5n76DndvOyQ9PlBppTcCtiBwnGjOGStYdzX Ok0C7eQFXiks31AdrXe0uazsmc_5s070gN.B8yQ1FB0.Q5VchhQwU.5RVZgH0QdYmFlpoTlJV.4z PstgEdvG0LRUnUQkqnOEeFXGNZsZe03Tbj_3R3QwNgm3z8k2xqIkCEsZltj0JuP_Ajj3Rijn3V1o AMg.Dtjt_inbvk5TLGGmcM93c6fv6yQWxwVHi6Ki.8GUucHy9jrkrrF8IfW6yauFZ199bQyW.Tvy CNa3WKr7j0QQMqw-- Received: by 98.138.105.204; Tue, 04 Aug 2015 23:15:27 +0000 Date: Tue, 4 Aug 2015 23:15:23 +0000 (UTC) From: Barney Cordoba Reply-To: Barney Cordoba To: hiren panchasara , Eric Joyner Cc: FreeBSD Net , Adrian Chadd Message-ID: <150756354.750462.1438730123217.JavaMail.yahoo@mail.yahoo.com> In-Reply-To: <20150715180138.GK8260@strugglingcoder.info> References: <20150715180138.GK8260@strugglingcoder.info> Subject: Re: Exposing full 32bit RSS hash from card for ixgbe(4) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2015 23:15:36 -0000 What's the point of all of this gobbledygook anyway? Seriously, 99% of the world needs a driver that passes packets in the most efficient way, and every time I look at igb and ixgbe it has another 2 heads. It's up to 8 heads, and none of the things wrong with it have been fixed. This is now even uglier than Kip Macy's cxgb abortion. I'm not trying to be snarky here. I wrote a simple driver 3 years ago that runs and runs and uses little cpu; maybe 8% for a full gig load on an E3. What is the benefit of implementing all of these stupid offload and RSS hashes? Spreading across cpus is incredibly inefficient; running 8 'queues' on a quad core cpu with hyperthreading is incredibly stupid. 1 cpu can easily handle a full gig, so why are you dirtying the code with 8000 "features" when it runs just fine without any of them? you're subjecting 1000s of users to constant instability (and fear in upgrading at all) for what amounts to a college science project. I know you haven't benchmarked it, so why are you doing it? hell, you added that buf_ring stuff without even making any determination that it was beneficial to use it, just because it was there. You're trying to steal a handful of cycles with these hokey features, and then you're losing buckets of cycles (maybe wheelbarrows) by unnecessarily spreading the processes across too many cpus. It just makes no sense at all. If you want to play, that's fine. But there should be simple I/O drivers for em, igb and ixgbe available as alternatives for the 99% of users who just want to run a router, a bridge/filter or a web server. Drivers that don't break features A and C when you make a change to Q and Z because you can't possibly test all 8000 features every time you do something. Im horrified that some poor schlub with a 1 gig webserver is losing half of his cpu power because of the ridiculous defaults in the igb driver. On Wednesday, July 15, 2015 2:01 PM, hiren panchasara wrote: On 07/14/15 at 02:18P, hiren panchasara wrote: > On 07/14/15 at 12:38P, Eric Joyner wrote: > > Sorry for the delay; it looked fine to me, but I never got back to you. > > > > - Eric > > > > On Mon, Jul 13, 2015 at 3:16 PM Adrian Chadd wrote: > > > > > Hi, > > > > > > It's fine by me. Please do it! > > Thanks Adrian and Eric. Committed as r285528. FYI: I am planning to do a partial mfc of this to stable10. Here is the patch: https://people.freebsd.org/~hiren/patches/ix_expose_rss_hash_stable10.patch (I did the same for igb(4), r282831) Cheers, Hiren From owner-freebsd-net@freebsd.org Tue Aug 4 23:32:19 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A7249B3D4C for ; Tue, 4 Aug 2015 23:32:19 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-ob0-x234.google.com (mail-ob0-x234.google.com [IPv6:2607:f8b0:4003:c01::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5FF571EA8 for ; Tue, 4 Aug 2015 23:32:19 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: by obdeg2 with SMTP id eg2so19312078obd.0 for ; Tue, 04 Aug 2015 16:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=w2dcTrmdpZx3x4tINUliJqU7ULJzNnIt78mbrP5+rBg=; b=Gtx/VysAb74Gc6xYjsyswJsZyzxiNcjaoPJA1KcBJ1GJYTd6tYiUAe/NjzdRQARgwW CXIgD/PWSbcCaEUiXtO//xW4coad39lfD6GP56sLKbfjtUyzUL58Fy6LXrKhPC82ByQE g5fCI9UEcA1m9sCHHsJIswcI6nGqVMEmkpQNiDAh9B/OWgQ56lNRUcBBconKpqCVciY4 h+7TVyrMmvjR3CT5+Jki4hUDUuHp8NCnlDGhLGJK7yjQSjfaAIOZCNXzQndduHo0SKdk TCnpU76El/bN0LPNBUUN6xT5N/udbaeIOAaQdo8INUxO8R8EaAzlOvztQ0Em/DmIqKwT t21Q== MIME-Version: 1.0 X-Received: by 10.60.58.225 with SMTP id u1mr5436603oeq.75.1438731138745; Tue, 04 Aug 2015 16:32:18 -0700 (PDT) Sender: kob6558@gmail.com Received: by 10.202.221.69 with HTTP; Tue, 4 Aug 2015 16:32:18 -0700 (PDT) In-Reply-To: <55C14723.8010601@swin.edu.au> References: <55C14723.8010601@swin.edu.au> Date: Tue, 4 Aug 2015 16:32:18 -0700 X-Google-Sender-Auth: oC_7xSISqJ3lzJ5MtVxkEX8rNCs Message-ID: Subject: Re: bugzilla chatter? From: Kevin Oberman To: grenville armitage Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2015 23:32:19 -0000 On Tue, Aug 4, 2015 at 4:13 PM, grenville armitage wrote: > > > > I'm curious about the uptick of bugzilla chatter turning up in freebsd-net@ > the last few days. > > Whilst I can filter it locally, I'm puzzled as to why it would be a Good > Thing for bugzilla bugs to be "Assigned to" freebsd-net. > > cheers, > gja > > > Yes, Sean has been VERY busy this week in cleaning up old Intel driver (em, igb, ixgb, etc) tickets. I, for one, have no problem with seeing them. They are easy for those who would prefer not to see them and provide a fair bit up useful information and a reasonable "heads-up" for problem status. I suspect that once Sean has hit most of the old (some really old) tickets, things will quiet down a fair bit. (But I could be wrong.) I love seeing tickets being taken care of. -- Kevin Oberman, Network Engineer, Retired E-mail: rkoberman@gmail.com PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683