From owner-cvs-sys  Mon Sep 15 01:14:28 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id BAA11608
          for cvs-sys-outgoing; Mon, 15 Sep 1997 01:14:28 -0700 (PDT)
Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5])
          by hub.freebsd.org (8.8.7/8.8.7) with SMTP id BAA11572;
          Mon, 15 Sep 1997 01:14:00 -0700 (PDT)
Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id IAA01948; Mon, 15 Sep 1997 08:56:38 +0200
From: Luigi Rizzo <luigi@labinfo.iet.unipi.it>
Message-Id: <199709150656.IAA01948@labinfo.iet.unipi.it>
Subject: Re: cvs commit: src/sys/i386/isa/snd - Imported sources
To: mike@smith.net.au (Mike Smith)
Date: Mon, 15 Sep 1997 08:56:38 +0200 (MET DST)
Cc: jmg@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org,
        cvs-sys@freebsd.org
In-Reply-To: <199709150644.QAA00618@word.smith.net.au> from "Mike Smith" at Sep 15, 97 04:14:00 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-cvs-sys@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

> The entire snd module is useless now that Peter has committed the 
> select->poll changes; it can't be built.

I am trying to figure out the difference between select and poll,
it does not appear to be anything substantial, i.e. just a change
in arguments in ("events" instead of "rw") and out ("revents"
instead of 0/1). Is there any documentation somewhere ?

On passing, it seems that sequences like the following (from
pcaudio.c, a similar thing is in asc.c) would be much easier to
read if replaced by selrecord(p, &pca_status.wsel ).

	if (pca_status.wsel.si_pid &&
		    (p1=pfind(pca_status.wsel.si_pid))
		    && p1->p_wchan == (caddr_t)&selwait)
		pca_status.wsel.si_flags = SI_COLL;
	else
		pca_status.wsel.si_pid = p->p_pid;


	Cheers
	Luigi
-----------------------------+--------------------------------------
Luigi Rizzo                  |  Dip. di Ingegneria dell'Informazione
email: luigi@iet.unipi.it    |  Universita' di Pisa
tel: +39-50-568533           |  via Diotisalvi 2, 56126 PISA (Italy)
fax: +39-50-568522           |  http://www.iet.unipi.it/~luigi/
_____________________________|______________________________________