From owner-svn-src-head@freebsd.org Sat May 19 16:58:56 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E886EDA5C6; Sat, 19 May 2018 16:58:56 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B99276832; Sat, 19 May 2018 16:58:56 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-io0-f179.google.com (mail-io0-f179.google.com [209.85.223.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 1697925449; Sat, 19 May 2018 16:58:56 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-io0-f179.google.com with SMTP id t23-v6so9841385ioc.10; Sat, 19 May 2018 09:58:56 -0700 (PDT) X-Gm-Message-State: ALKqPwdZ+z4b63WnrnzOwSd0AUIEEtdlJdh0yjzlF2/GywiIUnc2roZL /C/ZCn6w/pc1X22BQoWNGWI7xLG2UJ3YkpoiF7c= X-Google-Smtp-Source: AB8JxZrTDzJJQHFzPHoIxopaa5Ng2Wcn/EBSQI7CshBIrH2PSPKUz5H5QxqoMz7LAiRAd7uLDFTpuI5/LQFGMR6mdAE= X-Received: by 2002:a6b:a712:: with SMTP id q18-v6mr14854281ioe.237.1526749135378; Sat, 19 May 2018 09:58:55 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:85ae:0:0:0:0:0 with HTTP; Sat, 19 May 2018 09:58:55 -0700 (PDT) In-Reply-To: <838f63057df1cd9bc430ed76328c28b5@megadrive.org> References: <201805191335.w4JDZq9b015979@pdx.rh.CN85.dnsmgr.net> <29252c55ea65fe53b9ab4e673ec6726c@megadrive.org> <838f63057df1cd9bc430ed76328c28b5@megadrive.org> From: Matthew Macy Date: Sat, 19 May 2018 09:58:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333822 - head/sys/kern To: Emmanuel Vadot Cc: owner-src-committers@freebsd.org, rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 16:58:56 -0000 On Sat, May 19, 2018 at 8:56 AM, Emmanuel Vadot wrote: > On 2018-05-19 17:39, Matthew Macy wrote: >> >> On Sat, May 19, 2018 at 07:17 Emmanuel Vadot >> wrote: >> >>> On 2018-05-19 15:35, Rodney W. Grimes wrote: >>>> >>>> [ Charset UTF-8 unsupported, converting... ] >>>>> >>>>> Author: mmacy >>>>> Date: Sat May 19 02:15:40 2018 >>>>> New Revision: 333822 >>>>> URL: https://svnweb.freebsd.org/changeset/base/333822 [1] >>>>> >>>>> >>>>> Log: >>>>> fix gcc8 unused variable and set but not used variable in unix >>> >>> >>>>> sockets >>>>> add copyright from lock rewrite while here >>>>> >>>>> Modified: >>>>> head/sys/kern/uipc_usrreq.c >>>>> >>>>> Modified: head/sys/kern/uipc_usrreq.c >>>>> >>> >> >> ============================================================================== >>>>> >>>>> --- head/sys/kern/uipc_usrreq.c Sat May 19 00:47:24 2018 >>> >>> (r333821) >>>>> >>>>> +++ head/sys/kern/uipc_usrreq.c Sat May 19 02:15:40 2018 >>> >>> (r333822) >>>>> >>>>> @@ -4,7 +4,7 @@ >>>>> * Copyright (c) 1982, 1986, 1989, 1991, 1993 >>>>> * The Regents of the University of California. >>>>> * Copyright (c) 2004-2009 Robert N. M. Watson >>>>> - * All rights reserved. >>>> >>>> >>>> Did you have permission from Robert Watson to remove this? >>>> >>>>> + * Copyright (c) 2018 Matthew Macy >>>>> * >>>>> * Redistribution and use in source and binary forms, with or >>> >>> without >>>>> >>>>> * modification, are permitted provided that the following >>> >>> conditions >>>> >>>> ... >>> >>> >>> That also seems a small patch to add your name in the copyright. >> >> >> Uhh... Locking rewrite was a small patch? Really? > > > Maybe I should I read the previous commits and the full log here :) sorry. No problem. Thanks Warner for stepping up. I probably shouldn't respond before I've had my coffee. Just to be clear - I wasn't upset, just a bit flabbergasted. I clearly mentioned "locking rewrite" in the message and there were clearly no locking changes in this particular commit. The awake thing to do would have been to send a link to the commit itself and clarify that, although in pure line count was < 25%, it was a material change with substantial impact. https://svnweb.freebsd.org/base?view=revision&revision=333744 Cheers -M > >> >>> -- >>> Emmanuel Vadot >> >> >> >> Links: >> ------ >> [1] https://svnweb.freebsd.org/changeset/base/333822 > > > -- > Emmanuel Vadot