From owner-svn-src-all@FreeBSD.ORG Sun Dec 14 09:55:13 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0B2E106564A; Sun, 14 Dec 2008 09:55:13 +0000 (UTC) (envelope-from niclas.zeising@gmail.com) Received: from mxf2.bahnhof.se (mxf2.bahnhof.se [213.80.101.26]) by mx1.freebsd.org (Postfix) with ESMTP id 52CE48FC0C; Sun, 14 Dec 2008 09:55:13 +0000 (UTC) (envelope-from niclas.zeising@gmail.com) Received: from localhost (mxf2.local [127.0.0.1]) by mxf2-reinject (Postfix) with ESMTP id 415626BD072; Sun, 14 Dec 2008 10:27:27 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MXF2) X-Spam-Score: 2.777 X-Spam-Level: ** X-Spam-Status: No, score=2.777 tagged_above=-99 required=5 tests=[DNS_FROM_RFC_POST=1.708, SPF_NEUTRAL=1.069] Received: from mxf2.bahnhof.se ([127.0.0.1]) by localhost (mxf2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kvvUZK2Acp7X; Sun, 14 Dec 2008 10:27:26 +0100 (CET) Received: from [10.0.0.3] (h-85-24-219-30.NA.cust.bahnhof.se [85.24.219.30]) by mxf2.bahnhof.se (Postfix) with ESMTP id 28DC46BD035; Sun, 14 Dec 2008 10:27:26 +0100 (CET) Received: from 127.0.0.1 (AVG SMTP 8.0.176 [270.9.17/1847]); Sun, 14 Dec 2008 10:27:26 +0100 Message-ID: <4944D17E.9080900@gmail.com> Date: Sun, 14 Dec 2008 10:27:26 +0100 From: Niclas Zeising User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: Garrett Cooper References: <200812140906.mBE96SEZ054272@svn.freebsd.org> <7d6fde3d0812140108l4b0c75e1o229c667c0b86dd7e@mail.gmail.com> In-Reply-To: <7d6fde3d0812140108l4b0c75e1o229c667c0b86dd7e@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, Joseph Koshy , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186076 - head/sys/amd64/amd64 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Dec 2008 09:55:13 -0000 Garrett Cooper wrote: > On Sun, Dec 14, 2008 at 1:06 AM, Joseph Koshy wrote: >> Author: jkoshy >> Date: Sun Dec 14 09:06:28 2008 >> New Revision: 186076 >> URL: http://svn.freebsd.org/changeset/base/186076 >> >> Log: >> Bug fix: %ebx needs to be preserved in the user callchain capture >> path. >> >> Modified: >> head/sys/amd64/amd64/exception.S >> >> Modified: head/sys/amd64/amd64/exception.S >> ============================================================================== >> --- head/sys/amd64/amd64/exception.S Sun Dec 14 06:40:04 2008 (r186075) >> +++ head/sys/amd64/amd64/exception.S Sun Dec 14 09:06:28 2008 (r186076) >> @@ -459,9 +459,9 @@ nmi_calltrap: >> */ >> movq %rsp,%rsi /* source stack pointer */ >> movq $TF_SIZE,%rcx >> - movq PCPU(RSP0),%rbx >> - subq %rcx,%rbx >> - movq %rbx,%rdi /* destination stack pointer */ >> + movq PCPU(RSP0),%rdx >> + subq %rcx,%rdx >> + movq %rdx,%rdi /* destination stack pointer */ >> >> shrq $3,%rcx /* trap frame size in long words */ >> cld >> @@ -470,7 +470,7 @@ nmi_calltrap: >> >> movl %ss,%eax >> pushq %rax /* tf_ss */ >> - pushq %rbx /* tf_rsp (on kernel stack) */ >> + pushq %rdx /* tf_rsp (on kernel stack) */ ^^^^^^ >> pushfq /* tf_rflags */ >> movl %cs,%eax >> pushq %rax /* tf_cs */ > > Stupid question -- where's the change? All I see are potentially > whitespace modifications.. > -Garrett %rbx is changed to a %rdx in some places, I hilighted one. Regards! //Niclas