From owner-freebsd-embedded@FreeBSD.ORG  Wed Jan  4 04:24:34 2012
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: freebsd-embedded@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 31A82106566B
	for <freebsd-embedded@freebsd.org>;
	Wed,  4 Jan 2012 04:24:34 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com
	[209.85.212.54])
	by mx1.freebsd.org (Postfix) with ESMTP id DB42C8FC0C
	for <freebsd-embedded@freebsd.org>;
	Wed,  4 Jan 2012 04:24:33 +0000 (UTC)
Received: by vbbfr13 with SMTP id fr13so22422069vbb.13
	for <freebsd-embedded@freebsd.org>;
	Tue, 03 Jan 2012 20:24:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=PrPA3RyTFw1QnFLtnbuWvHbVbv4ouuQaFWcTQ+PfAL0=;
	b=tXDYn8n/6bdD+Zk4hnIyTYuhJyAWxL2cMAJQKcOFO2M2sJQG14G7f2cRveoltKKgGD
	kdoPaaU1bKI+plwAqfatsktor+z06Zf664AEqYbT0nhRvItgy8z+PSp2QzFksx6XaUtO
	5/L4qyXrV1SAR+Ildy0PmS6bRuBmwWePY4+IQ=
MIME-Version: 1.0
Received: by 10.52.23.44 with SMTP id j12mr19423022vdf.117.1325651073056; Tue,
	03 Jan 2012 20:24:33 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.52.36.5 with HTTP; Tue, 3 Jan 2012 20:24:33 -0800 (PST)
In-Reply-To: <CAJ-VmomL=v00uEN62V8NSFEoD9LcUg1KVW38HrXxT-gXnZoO4g@mail.gmail.com>
References: <C456CF98-0E0D-4563-8FDB-B77B8CF5B9E1@lassitu.de>
	<CAJ-VmomL=v00uEN62V8NSFEoD9LcUg1KVW38HrXxT-gXnZoO4g@mail.gmail.com>
Date: Tue, 3 Jan 2012 20:24:33 -0800
X-Google-Sender-Auth: rFoTv2NRhc9kI3-b4CDj8Ol_tCg
Message-ID: <CAJ-VmonwDFJzReS+RE6umGK8XoFwPOt=FGFAyOhYtOvjzM7sCQ@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Stefan Bethke <stb@lassitu.de>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-embedded@freebsd.org
Subject: Re: dev/etherswitch
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jan 2012 04:24:34 -0000

Hi,

Take a look at:

http://gitorious.org/~stb/freebsd/stb-adrianchadd-freebsd-work/commit/b31c2bc80e8328924802b24682a9d5ea77b13ebf

You have one commit messages but multiple things:

* You've added 'pinon', which lets you set a default output value. I
know at least one board required it for enabling USB power, why's the
tplink need it?
* Why'd you flip on bit 13 in the AR91xx GPIO function register? And
comment out the USB led device?
* You also changed the delay to three and commented it out. :-)

Some of this may need to be thrown back in -HEAD. So, can you provide
some more background info so I can see what needs to be merged back?
:)


Adrian