From nobody Mon May 25 19:22:18 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gPQkP2SCXz6fnrV; Mon, 25 May 2026 19:22:21 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mail03.stack.nl (lw02.stack.nl [85.17.116.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature ECDSA (prime256v1)) (Client CN "adm.stack.nl", Issuer "E8" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gPQkN70Bwz3Bns; Mon, 25 May 2026 19:22:20 +0000 (UTC) (envelope-from jilles@stack.nl) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=stack.nl; s=mail; t=1779736940; bh=goyPFQULQHDqFg/f3IB7JWEdtR+O/sNUZdImT3jID0k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SSvbEzhMyX6w8cW9JAaZfyvupKyCR5XXp4QlRBEKfbiYyT9+a9TZ7bP6wuF5hlYhg bEVAT3wu1wCkMgt35rFlfyrlrueQNsH2SdQgBOtXf4Hsygt5nAk+L7tllzFPj/hzYe f99KqriK0kfh3jBb2H4J5j6pvyGhwHC4V7NWPRACw4BNg2zOi6eJJGHAeFRgRC+gyy 9gxfTMoCTVjkqOMmlY4qE0O243HYlMBHHPUH+bnhBjSqn125Y+zzUwD1pzxcNw1rl4 aYKkkszN91Hv1COxTfvaSirgPDpj+mEUh5bRiUDZOxspa53mBAzU5bpGW/s6zZ7Zhu kTIliwR9Srt+Q== Received: from localhost (localhost.localdomain [127.0.0.1]) by mail03.stack.nl (Postfix) with ESMTP id 1A112A2510; Mon, 25 May 2026 21:22:20 +0200 (CEST) Received: from mail03.stack.nl ([127.0.0.1]) by localhost (mail03.stack.nl [127.0.0.1]) (amavis, port 10024) with ESMTP id jGWCx4ApwB4V; Mon, 25 May 2026 21:22:18 +0200 (CEST) Received: from blade.stack.nl (unknown [95.211.93.133]) by mail03.stack.nl (Postfix) with ESMTPS id 6A0CCA224D; Mon, 25 May 2026 21:22:18 +0200 (CEST) Received: by blade.stack.nl (Postfix, from userid 1677) id 5D47580513; Mon, 25 May 2026 21:22:18 +0200 (CEST) Date: Mon, 25 May 2026 21:22:18 +0200 From: Jilles Tjoelker To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1df431576f99 - main - sh/tests: Cut down builtins/read12.0 by 2 seconds Message-ID: References: <6a120625.45836.5e8588e2@gitrepo.freebsd.org> <86h5nx3e8b.fsf@ltc.des.dev> <865x4c2bfn.fsf@ltc.des.dev> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <865x4c2bfn.fsf@ltc.des.dev> X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:60781, ipnet:85.17.0.0/16, country:NL] X-Rspamd-Queue-Id: 4gPQkN70Bwz3Bns X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Mon, May 25, 2026 at 09:30:36AM +0200, Dag-Erling Smørgrav wrote: > Jilles Tjoelker writes: > > Dag-Erling Smørgrav writes: > > > Please revert the non-functional parts of this change. > > Please explain what you are worried about in the change. Is this about > > false positives or false negatives? > The purpose of a test is to reliably fail if the functionality it tests > is broken. Your change turns my test from one that is fairly certain to > fail if the timeout functionality is broken to one that has a reasonable > chance of passing regardless. What's more, you justify the change with > a logical argument so fallacious that you _still_ refuse to explain it. > All that just to save yourself a couple of seconds once in a while, even > after I showed you how to save much more than two seconds simply by > enabling parallelism. Please revert, or I will. I have reverted the entire commit. Let's leave it as is until I understand what the problem is. -- Jilles Tjoelker