From owner-freebsd-stable@FreeBSD.ORG Mon May 22 17:42:26 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB11616AA1E; Mon, 22 May 2006 17:42:26 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from aaron.protected-networks.net (aaron.protected-networks.net [202.12.127.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id A33D943D69; Mon, 22 May 2006 17:42:18 +0000 (GMT) (envelope-from imb@protected-networks.net) Received: from localhost (localhost [127.0.0.1]) by aaron.protected-networks.net (Postfix) with ESMTP id 5F484C343; Mon, 22 May 2006 13:42:17 -0400 (EDT) Received: from aaron.protected-networks.net (localhost [127.0.0.1]) by aaron.protected-networks.net (Postfix) with ESMTP id B38F9C332; Mon, 22 May 2006 13:42:09 -0400 (EDT) Authentication-Results: aaron.protected-networks.net from=imb@protected-networks.net; domainkey=pass Received: from aaron.protected-networks.net (localhost [127.0.0.1]) by aaron.protected-networks.net (Postfix) with ESMTP id 3F2C2C2FA; Mon, 22 May 2006 13:42:09 -0400 (EDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=200509; d=protected-networks.net; h=Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=XcDLK0FsxbRPHLGFwZz+lCw14hqY4Ae3M3wpePEUbMrlqy5BnXTTJLSf1O4fxFKO+fO71/IZcLMUeW9K6hEoautpqwwY+Se/j8hfExGCzzl3z4pO1LlqDab35EjkpRmi; Received: from [192.168.1.11] (c-24-218-147-31.hsd1.ma.comcast.net [24.218.147.31]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "Iain Michael Butler", Issuer "Protected Networks Certificate Authority" (verified OK)) by aaron.protected-networks.net (Postfix) with ESMTP id A75E7C2F8; Mon, 22 May 2006 13:42:06 -0400 (EDT) Message-ID: <4471F7EC.1080301@protected-networks.net> Date: Mon, 22 May 2006 13:42:04 -0400 From: Michael Butler User-Agent: Thunderbird 1.5.0.2 (Windows/20060308) MIME-Version: 1.0 To: Robert Watson References: <4471C021.30602@protected-networks.net> <20060522175934.T32297@fledge.watson.org> In-Reply-To: <20060522175934.T32297@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-stable@freebsd.org Subject: Re: requests for mbufs denied? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2006 17:42:29 -0000 Robert Watson wrote: > This is believed to be a result of an error in the statistics > measurement logic in UMA. I've committed the attached patch to the > CVS HEAD, and am looking for feedback over the next couple of weeks > before merging to RELENG_6 (and possibly the errata branches). Any > testing and reports of success or failure would be most welcome. I've just installed the RELENG_6 equivalent of this patch (below) on 3 machines and will let you know if I see anything untoward, *** uma_core.c.orig Tue Feb 14 08:16:40 2006 --- uma_core.c Mon May 22 13:09:26 2006 *************** *** 2417,2424 **** * If nothing else caught this, we'll just do an internal free. */ zfree_internal: ! uma_zfree_internal(zone, item, udata, SKIP_DTOR, ZFREE_STATFAIL | ! ZFREE_STATFREE); return; } --- 2417,2423 ---- * If nothing else caught this, we'll just do an internal free. */ zfree_internal: ! uma_zfree_internal(zone, item, udata, SKIP_DTOR, ZFREE_STATFREE); return; } -- Michael Butler, CISSP Security Architect Protected Networks http://www.protected-networks.net