From owner-freebsd-current@freebsd.org Sun Feb 18 22:50:28 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89561F0CD4D for ; Sun, 18 Feb 2018 22:50:28 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1A3FC70928 for ; Sun, 18 Feb 2018 22:50:28 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id C8885F0CD3F; Sun, 18 Feb 2018 22:50:27 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B65A0F0CD3E for ; Sun, 18 Feb 2018 22:50:27 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B50270922; Sun, 18 Feb 2018 22:50:27 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lf0-f45.google.com with SMTP id 37so10688880lfs.7; Sun, 18 Feb 2018 14:50:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wVcQ9DfQ/hPzjVabkr0UsmwGDQzY6abJ/OK5xa5YWZo=; b=AyijzEuBl8z7DOm/fH37SkTjBmQmaIe5kFLhKlb2N8TNo4CFWH+iA8KPQboT7K1evi JidkzaXJtRm5T6qz01np2ebsSwNoYRxOG3nmJqrbJEY7P3Up/UFhU4PJxpTel+kg3KSN eJh9a7kA3t11VtNpEsXMmNNSZNVE+IgYkPGPhuiolB5yUbhSLWIj8IGebxbELFoWHLaz MZG1JHjjgB8UFo+QHG3U2cPv/TUozhirDKoAUHEUCshYrMzItIy+xW6mL4dr2+/o7dKx OHvycGUVrNrIbyhooBY/jgUyXO/321CJEaFUjZANb520Id65DZOnNL+VcgC37jjFKArd 91Ew== X-Gm-Message-State: APf1xPD+3/d/TDg2F5THe3fclgjqQ/+LhpS+kX4asC49yeamw+KWXvev /dG8SXhCCBOY6dWoh3tNN5Slm8zx X-Google-Smtp-Source: AH8x226WAsZiFrit2qayVRBe7pkcEOi/UPBADyE9eof9QhGpIZDnX0aM66OSX16fcPG11cUSjlByow== X-Received: by 10.25.42.81 with SMTP id f78mr9005971lfl.100.1518994219952; Sun, 18 Feb 2018 14:50:19 -0800 (PST) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id m74sm29672lfe.85.2018.02.18.14.50.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Feb 2018 14:50:18 -0800 (PST) Subject: Re: Since last week (today) current on my Ryzen box is unstable To: Gleb Smirnoff Cc: Andrew Reilly , kib@FreeBSD.org, current@FreeBSD.org References: <0CEA9D55-D488-42EC-BBDE-D0B7CE58BAEA@bigpond.net.au> <20180218023545.GE93303@FreeBSD.org> <431f3e00-c66a-8e2e-6c61-a315a6353d1d@FreeBSD.org> <20180218132623.GF93303@FreeBSD.org> <359681a7-3885-820e-1ac8-19254c83d1ad@FreeBSD.org> <20180218203358.GG93303@FreeBSD.org> From: Andriy Gapon Message-ID: <23215dca-663f-1f0d-10ce-aaf7cf3c5d68@FreeBSD.org> Date: Mon, 19 Feb 2018 00:50:17 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180218203358.GG93303@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Feb 2018 22:50:28 -0000 On 18/02/2018 22:33, Gleb Smirnoff wrote: > On Sun, Feb 18, 2018 at 10:15:24PM +0200, Andriy Gapon wrote: > A> On 18/02/2018 15:26, Gleb Smirnoff wrote: > A> > My only point is that it is a performance improvement. IMHO that's enough :) > A> > A> I don't think that passing an invalid argument to a documented KPI is "enough" > A> for any optimization. > > I don't see a sense in making this KPI so sacred. This is something used internally > in kernel, and not used outside. The KPI has changed several times in the past. I don't have anything against changing KPI. At the same time think that it should be well-defined at all times. > A> > If you can't suggest a more elegant way of doing that improvement, then all > A> > I can suggest is to document it and add its support to ZFS. > A> > A> In return I can only suggest that (1) you run your suggestion by arch@ -- unless > A> that's already been done and you can point me to the discussion, (2) document > A> it and (3) double-check that all implementations confirm to it. > > I can provide a patch for ZFS. Thank you. But I think that the documentation update will be much more valuable. -- Andriy Gapon