From owner-svn-src-all@FreeBSD.ORG Fri Oct 29 18:29:27 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9FC64106564A; Fri, 29 Oct 2010 18:29:27 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 280A48FC19; Fri, 29 Oct 2010 18:29:26 +0000 (UTC) Received: by qyk2 with SMTP id 2so2336809qyk.13 for ; Fri, 29 Oct 2010 11:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=Z4qz/ApwvUCTgBPkUx036AtHDueSc1ivXqnn8SBpFOA=; b=YvU/ntooXPTMqBx+y2yS1fn930j3h/ZhHvKSeJJk77fgk9xQYZ7x8RTiRyc4/W5khH AsWA+Ukd6YH8wNNoQX6zHEBJI55Sz/JpqjhAPs5A19qA0zKemPQY8+qgvDnQ8dHSo2N3 zHjQdQxb7r8BFMozsfs8DjMqNcknnxTPnX78s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Rp+JJEOiinyYNv92jrlNZrD6hnGGp01gsrMWy+oH2s/EuUP00FGfwhZU9+gxLGC+c6 1cnVeoYGQNo1pqKcuXaEyURGM7GnLhrrCYWEY6RTtd7BDupX7cUgpTwrBDAEAHs+3CdC BK2uG9ad9NaA6otewzenEVM075mZ/SzI6pFKI= MIME-Version: 1.0 Received: by 10.229.97.68 with SMTP id k4mr12122457qcn.261.1288376965793; Fri, 29 Oct 2010 11:29:25 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.229.237.9 with HTTP; Fri, 29 Oct 2010 11:29:25 -0700 (PDT) In-Reply-To: <201010291339.18565.jkim@FreeBSD.org> References: <201010280758.o9S7w6Vj069186@svn.freebsd.org> <201010291339.18565.jkim@FreeBSD.org> Date: Fri, 29 Oct 2010 20:29:25 +0200 X-Google-Sender-Auth: bE3mvVxgr4fLi2tOXJTRf4nXa1Y Message-ID: From: Attilio Rao To: Jung-uk Kim Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r214446 - in head/sys: amd64/amd64 conf i386/i386 x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2010 18:29:27 -0000 2010/10/29 Jung-uk Kim : > On Thursday 28 October 2010 03:58 am, Attilio Rao wrote: >> Author: attilio >> Date: Thu Oct 28 07:58:06 2010 >> New Revision: 214446 >> URL: http://svn.freebsd.org/changeset/base/214446 >> >> Log: >> =C2=A0 Merge the mptable support from MD bits to x86 subtree. >> >> =C2=A0 Sponsored by: =C2=A0 =C2=A0 =C2=A0 Sandvine Incorporated >> =C2=A0 Discussed with: =C2=A0 =C2=A0 jhb > > This commit broke amd64 build with "device mptable". =C2=A0I had to do th= e > following to fix sys/x86/x86/mptable.c: > > @@ -27,7 +27,9 @@ > =C2=A0#include > =C2=A0__FBSDID("$FreeBSD$"); > > +#ifdef __i386__ > =C2=A0#include "opt_mptable_force_htt.h" > +#endif > =C2=A0#include > =C2=A0#include > =C2=A0#include > > Alternatively, you may add "MPTABLE_FORCE_HTT" in > sys/conf/options.amd64 but I am not sure this option is useful for > amd64. Gosh, I left it out. Yes, I think this should be the right fix. Thanks, Attilio --=20 Peace can only be achieved by understanding - A. Einstein