From owner-cvs-all Thu Oct 24 11:13:11 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4457A37B4FD for ; Thu, 24 Oct 2002 11:12:59 -0700 (PDT) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0087F43E91 for ; Thu, 24 Oct 2002 11:12:58 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 5898 invoked from network); 24 Oct 2002 18:13:03 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 24 Oct 2002 18:13:03 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id g9OICtn5071699; Thu, 24 Oct 2002 14:12:56 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200210241759.g9OHxwqQ016414@repoman.freebsd.org> Date: Thu, 24 Oct 2002 14:12:59 -0400 (EDT) From: John Baldwin To: Luigi Rizzo Subject: RE: cvs commit: src/etc MAKEDEV Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 24-Oct-2002 Luigi Rizzo wrote: > luigi 2002/10/24 10:59:58 PDT > > Modified files: > etc MAKEDEV > Log: > Fix a bug in MAKEDEV -- when creating /dev/usb, the code was using > whatever random value was already in $unit. It happened to work > because the variable is often unset, but this is not always the > case e.g. when you call "MAKEDEV sio2 usb ..." > > This affects -stable as well. > > Reviewed by: n_hibma > Silence from: re > MFC after: 3 days 1) You do not need re@ approval for minor bugfixes such as this. 2) I (personally) have no record of an e-mail requesting approval for this patch in my re@ inbox, so it's not like re@ ignored this patch. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message