From owner-svn-src-all@FreeBSD.ORG Fri May 4 17:23:24 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 188CC106564A; Fri, 4 May 2012 17:23:24 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 909738FC0C; Fri, 4 May 2012 17:23:17 +0000 (UTC) Received: from [10.30.101.53] ([209.117.142.2]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id q44HJ2Ee032710 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Fri, 4 May 2012 11:19:03 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <201205041826.19435.hselasky@c2i.net> Date: Fri, 4 May 2012 11:18:56 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201205041538.q44FclqK010547@svn.freebsd.org> <201205041214.16342.jhb@freebsd.org> <201205041826.19435.hselasky@c2i.net> To: Hans Petter Selasky X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Fri, 04 May 2012 11:19:03 -0600 (MDT) Cc: "svn-src-stable@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "svn-src-stable-9@freebsd.org" , John Baldwin Subject: Re: svn commit: r235007 - stable/9/sys/dev/pci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2012 17:23:24 -0000 On May 4, 2012, at 10:26 AM, Hans Petter Selasky wrote: > On Friday 04 May 2012 18:14:16 John Baldwin wrote: >> On Friday, May 04, 2012 11:38:47 am Hans Petter Selasky wrote: >>> Author: hselasky >>> Date: Fri May 4 15:38:47 2012 >>> New Revision: 235007 >>> URL: http://svn.freebsd.org/changeset/base/235007 >>>=20 >>> Log: >>> MFC r233662, r233677 and r233678: >>>=20 >>> Writing zero to BAR actually does not disable it and >>> it is even harmful as hselasky found out. Historically, >>> this code was originated from (OLDCARD) CardBus driver and later = leaked >>> into PCI driver when CardBus was newbus'ified and refactored with = PCI >>> driver. However, it is not really necessary even for CardBus. >>=20 >> FYI, I've got one bug report on HEAD where these changes broke a = machine's >> ATA controller. >=20 > Have you considered adding code to disable the I/O or memory range = instead of=20 > writing 0 to the bar in this case? I tried that once upon a time, but was problematical with some bridges = that had BARs at non-standard locations that needed the I/O or MEM bit = set in order to work... Warner