From owner-freebsd-current Wed May 1 16:46:47 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id QAA02928 for current-outgoing; Wed, 1 May 1996 16:46:47 -0700 (PDT) Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id QAA02921 for ; Wed, 1 May 1996 16:46:45 -0700 (PDT) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <19760(8)>; Wed, 1 May 1996 16:40:39 PDT Received: from localhost ([127.0.0.1]) by crevenia.parc.xerox.com with SMTP id <177475>; Wed, 1 May 1996 16:40:24 -0700 X-Mailer: exmh version 1.6.4 10/10/95 To: Poul-Henning Kamp cc: current@freebsd.org (FreeBSD-current) Subject: Re: local router<->router UDP traffic: log_in_vain stuff error In-reply-to: Your message of "Sat, 27 Apr 1996 02:57:05 PDT." <2748.830599025@critter.tfs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 1 May 1996 16:40:21 PDT From: Bill Fenner Message-Id: <96May1.164024pdt.177475@crevenia.parc.xerox.com> Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk In message <2748.830599025@critter.tfs.com>you write: >> It was RIP packets from my service provider which cause >> local router to router UDP traffic. It seems that kernel >> treats remote UDP traffic as local when udp.log_in_vain used. > >Uhm this doesn't make any sense to me, the log_in_vain change was the >addition of this bit of code: > > if (log_in_vain) > log(LOG_INFO, "Connection attempt to UDP %s:%d" > " from %s:%d\n", > inet_ntoa(ip->ip_dst), ntohs(uh->uh_dport), > inet_ntoa(ip->ip_src), ntohs(uh->uh_sport)); Someone (I don't remember who, perhaps pst) pointed out shortly after this was committed that inet_ntoa() uses a static buffer so this will just log the same address twice. At least, I didn't point it out because I thought someone else had. Bill