From owner-cvs-src-old@FreeBSD.ORG Thu Nov 13 19:10:29 2008 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5395110656A6 for ; Thu, 13 Nov 2008 19:10:29 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 499178FC27 for ; Thu, 13 Nov 2008 19:10:29 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mADJATKL066877 for ; Thu, 13 Nov 2008 19:10:29 GMT (envelope-from ed@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mADJATpg066876 for cvs-src-old@freebsd.org; Thu, 13 Nov 2008 19:10:29 GMT (envelope-from ed@repoman.freebsd.org) Message-Id: <200811131910.mADJATpg066876@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to ed@repoman.freebsd.org using -f From: Ed Schouten Date: Thu, 13 Nov 2008 19:05:27 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/telnet/telnetd ext.h sys_term.c src/libexec/telnetd Makefile X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2008 19:10:29 -0000 ed 2008-11-13 19:05:27 UTC FreeBSD src repository Modified files: contrib/telnet/telnetd ext.h sys_term.c libexec/telnetd Makefile Log: SVN rev 184935 on 2008-11-13 19:05:27Z by ed Convert telnetd(8) to use posix_openpt(2). Some time ago I got some reports MPSAFE TTY broke telnetd(8). Even though it turned out to be a different problem within the TTY code, I spotted a small issue with telnetd(8). Instead of allocating PTY's using openpty(3) or posix_openpt(2), it used its own PTY allocation routine. This means that telnetd(8) still uses /dev/ptyXX-style devices. I've also increased the size of line[]. Even though 16 should be enough, we already use 13 bytes ("/dev/pts/999", including '\0'). 32 bytes gives us a little more freedom. Also enable -DSTREAMSPTY. Otherwise telnetd(8) strips the PTY's pathname to the latest slash instead of just removing "/dev/" (e.g. /dev/pts/0 -> 0, instead of pts/0). Reviewed by: rink Revision Changes Path 1.12 +1 -1 src/contrib/telnet/telnetd/ext.h 1.19 +18 -33 src/contrib/telnet/telnetd/sys_term.c 1.33 +2 -1 src/libexec/telnetd/Makefile