From owner-freebsd-net@FreeBSD.ORG  Wed Nov 12 12:49:50 2003
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CF25C16A4CE
	for <freebsd-net@freebsd.org>; Wed, 12 Nov 2003 12:49:50 -0800 (PST)
Received: from mailtoaster1.pipeline.ch (mailtoaster1.pipeline.ch
	[62.48.0.70])	by mx1.FreeBSD.org (Postfix) with ESMTP id E822243FEA
	for <freebsd-net@freebsd.org>; Wed, 12 Nov 2003 12:49:47 -0800 (PST)
	(envelope-from oppermann@pipeline.ch)
Received: (qmail 24248 invoked from network); 12 Nov 2003 20:52:39 -0000
Received: from unknown (HELO pipeline.ch) ([62.48.0.53])
          (envelope-sender <oppermann@pipeline.ch>)
          by mailtoaster1.pipeline.ch (qmail-ldap-1.03) with SMTP
          for <ume@mahoroba.org>; 12 Nov 2003 20:52:39 -0000
Message-ID: <3FB29CEA.1F5B9149@pipeline.ch>
Date: Wed, 12 Nov 2003 21:49:46 +0100
From: Andre Oppermann <oppermann@pipeline.ch>
X-Mailer: Mozilla 4.76 [en] (Windows NT 5.0; U)
X-Accept-Language: en
MIME-Version: 1.0
To: Hajimu UMEMOTO <ume@mahoroba.org>
References: <3FAE68FB.64D262FF@pipeline.ch>
	<ygey8um974u.wl%ume@mahoroba.org>		<3FB129E1.5D8F4D16@pipeline.ch>
	<ygellqmekws.wl%ume@mahoroba.org>
	<3FB2503E.53B21470@pipeline.ch> <yge8ymlba9f.wl%ume@mahoroba.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: freebsd-net@freebsd.org
cc: freebsd-current@freebsd.org
cc: mb@imp.ch
cc: sam@errno.com
Subject: Re: tcp hostcache and ip fastforward for review
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Nov 2003 20:49:50 -0000

Hajimu UMEMOTO wrote:
> 
> Hi,
> 
> >>>>> On Wed, 12 Nov 2003 16:22:38 +0100
> >>>>> Andre Oppermann <oppermann@pipeline.ch> said:
> 
> oppermann> Ok, I found the bug. It was in the ipv6 hash function where I made
> oppermann> a mistake with the hashmask.
> oppermann> The updated patch is here:
> oppermann>  http://www.nrg4u.com/freebsd/tcphostcache+ipfastforward-20031112.patch
> oppermann> Could you try again please?
> 
> It does repeatable panic.  Unfortunately, my laptop hanguped during
> dumping core, and I couldn't get core.  So, I copied the output from
> ddb by hand.
-snip-
> Stopped at      in6_selecthlim+0x35:    cmpl    $0,0x1c(%esi)
> db> trace
> in6_selecthlim(0,0,28,0,fadd8ac9) at in6_selecthlim+0x35
> syncache_respond(c3f6f000,c19a0600,1,c19a0600,0) at syncache_respond+0x31c

Grmpf... That is a logic error by me. Please add the following check
on line 707 in the patched netinet6/in6_src.c:

	else if (in6p && !IN6_IS_ADDR_UNSPECIFIED(&in6p->in6p_faddr)) {
                 ^^^^ ^^

Thank you for your effort in testing my changes!

-- 
Andre