From owner-cvs-all@FreeBSD.ORG  Fri Mar  2 19:01:21 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 652B916A400;
	Fri,  2 Mar 2007 19:01:21 +0000 (UTC) (envelope-from mij@bitchx.it)
Received: from aa014msr.fastwebnet.it (aa014msr.fastwebnet.it [85.18.95.74])
	by mx1.freebsd.org (Postfix) with ESMTP id E734613C48E;
	Fri,  2 Mar 2007 19:01:20 +0000 (UTC) (envelope-from mij@bitchx.it)
Received: from [1.11.158.102] (1.11.158.102) by aa014msr.fastwebnet.it
	(7.3.105.6) id 45E7F4020007A309; Fri, 2 Mar 2007 19:50:05 +0100
In-Reply-To: <20070302164917.GA28444@xor.obsecurity.org>
References: <200703011006.l21A6EKZ036332@repoman.freebsd.org>
	<20070302164917.GA28444@xor.obsecurity.org>
Mime-Version: 1.0 (Apple Message framework v752.3)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <44226B29-C2D1-4CF9-A0F9-FC661D5691C5@bitchx.it>
Content-Transfer-Encoding: 7bit
From: Mij <mij@bitchx.it>
Date: Fri, 2 Mar 2007 19:49:42 +0100
To: Kris Kennaway <kris@obsecurity.org>
X-Mailer: Apple Mail (2.752.3)
Cc: cvs-ports@FreeBSD.org, Cheng-Lung Sung <clsung@FreeBSD.org>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/security/sshguard Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Mar 2007 19:01:21 -0000


On 02/mar/07, at 17:49, Kris Kennaway wrote:

> On Thu, Mar 01, 2007 at 10:06:14AM +0000, Cheng-Lung Sung wrote:
>> clsung      2007-03-01 10:06:14 UTC
>>
>>   FreeBSD ports repository
>>
>>   Modified files:
>>     security/sshguard    Makefile
>>   Log:
>>   - respect maintainer's insist on interactive part,
>>     even IS_INTERACTIVE is discouraged

not glad to see such comment


> This is disappointing.  Can the maintainer explain why?

the app requires the user to choose what firewall to support for  
building: IPFW or PF.
They are in XOR and there is no reasonable default in this.

Cheng-Lung chose PF default and removed is_interactive.
A feedback request would have avoided this qui pro quo.


>>   - PORTREVISION is thus bumped.
>>
>>   Approved by:    maintainer (implicit)
>
>> | +.if ! ( (defined(WITH_PF) && !defined(WITH_IPFW)) || !defined 
>> (WITH_PF))
>> | +# some error occurred. Configure will handle this.
>> | +.endif
>
> And what is this? :)

this used to be ".error blah"  for checking the options' XOR-ness,  
then removed because
options are also set when deinstalling/cleaning etc. Definitely  
useless, replacing with a
comment about the problem appears the best to do. Actually I dunno  
why this made its way
in the submission :)

bye