Date: Sat, 23 Jan 2021 08:29:55 +0100 From: Antoine Brodin <antoine@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 86f33b5fcf60 - main - elfctl: allow features to be specified by value Message-ID: <CAALwa8nscmUwAANWK2TBdzkay9DuhFSuNfZPKEBwefWwo2JhMg@mail.gmail.com> In-Reply-To: <202101221940.10MJeTcd061452@gitrepo.freebsd.org> References: <202101221940.10MJeTcd061452@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 22, 2021 at 8:40 PM Ed Maste <emaste@freebsd.org> wrote: > > The branch main has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=86f33b5fcf6087bf4439881011b920ff99e6e300 > > commit 86f33b5fcf6087bf4439881011b920ff99e6e300 > Author: Ed Maste <emaste@FreeBSD.org> > AuthorDate: 2021-01-22 17:22:35 +0000 > Commit: Ed Maste <emaste@FreeBSD.org> > CommitDate: 2021-01-22 19:38:52 +0000 > > elfctl: allow features to be specified by value > > This will allow elfctl on older releases to set bits that are not yet > known there, so that the binary will have the correct settings applied > if run on a later FreeBSD version. > > PR: 252629 (related) > Suggested by: kib > Reviewed by: gbe (manpage, earlier), kib > MFC after: 3 days > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D28284 This fails to build: --- all_subdir_usr.bin --- --- all_subdir_usr.bin/elfctl --- /usr/local/poudriere/jails/main-i386/usr/src/usr.bin/elfctl/elfctl.c:258:18: error: comparison of integers of different signs: 'long' and 'unsigned int' [-Werror,-Wsign-compare] --- all_subdir_lib --- --- powitf2.po --- --- all_subdir_usr.bin --- else if (val > UINT_MAX) ~~~ ^ ~~~~~~~~ --- all_subdir_lib --- Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8nscmUwAANWK2TBdzkay9DuhFSuNfZPKEBwefWwo2JhMg>