From owner-p4-projects@FreeBSD.ORG  Tue Jan  1 22:35:42 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8D88016A421; Tue,  1 Jan 2008 22:35:42 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 519E616A418
	for <perforce@freebsd.org>; Tue,  1 Jan 2008 22:35:42 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 276B713C43E
	for <perforce@freebsd.org>; Tue,  1 Jan 2008 22:35:42 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m01MZgOX055116
	for <perforce@freebsd.org>; Tue, 1 Jan 2008 22:35:42 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m01MZg9b055113
	for perforce@freebsd.org; Tue, 1 Jan 2008 22:35:42 GMT
	(envelope-from jb@freebsd.org)
Date: Tue, 1 Jan 2008 22:35:42 GMT
Message-Id: <200801012235.m01MZg9b055113@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 132265 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jan 2008 22:35:42 -0000

http://perforce.freebsd.org/chv.cgi?CH=132265

Change 132265 by jb@jb_freebsd1 on 2008/01/01 22:34:48

	Revise the profile provider:
	- Add a SYSUNINIT.
	- Move code from modevent to load/unload.
	- Remove memory type M_PROFILE as it isn't used.
	- Add a dependency on the opensolaris module.

Affected files ...

.. //depot/projects/dtrace/src/sys/cddl/dev/profile/profile.c#3 edit

Differences ...

==== //depot/projects/dtrace/src/sys/cddl/dev/profile/profile.c#3 (text+ko) ====

@@ -18,7 +18,7 @@
  *
  * CDDL HEADER END
  *
- * Portions Copyright 2006 John Birrell jb@freebsd.org
+ * Portions Copyright 2006-2008 John Birrell jb@freebsd.org
  *
  * $FreeBSD$
  *
@@ -32,7 +32,6 @@
 #include <sys/cdefs.h>
 #include <sys/param.h>
 #include <sys/systm.h>
-#include <sys/bus.h>
 #include <sys/conf.h>
 #include <sys/cpuvar.h>
 #include <sys/fcntl.h>
@@ -55,12 +54,9 @@
 #include <sys/unistd.h>
 #include <machine/stdarg.h>
 
-#include <sys/cyclic_impl.h>
-#include <sys/dtrace_impl.h>
-
-MALLOC_DECLARE(M_PROFILE);
-MALLOC_DEFINE(M_PROFILE, "profile", "Dynamic Interrupt Tracing");
-#define M_KMEM			M_PROFILE
+#include <sys/cyclic.h>
+#include <sys/dtrace.h>
+#include <sys/dtrace_bsd.h>
 
 #define	PROF_NAMELEN		15
 
@@ -479,6 +475,10 @@
 static void
 profile_load(void *dummy)
 {
+	/* Create the /dev/dtrace/profile entry. */
+	profile_cdev = make_dev(&profile_cdevsw, 0, UID_ROOT, GID_WHEEL, 0600,
+	    "dtrace/profile");
+
 	if (dtrace_register("profile", &profile_attr, DTRACE_PRIV_USER,
 	    NULL, &profile_pops, NULL, &profile_id) != 0)
 		return;
@@ -506,13 +506,9 @@
 
 	switch (type) {
 	case MOD_LOAD:
-		/* Create the /dev/dtrace/profile entry. */
-		profile_cdev = make_dev(&profile_cdevsw, 0, UID_ROOT, GID_WHEEL, 0600,
-		    "dtrace/profile");
 		break;
 
 	case MOD_UNLOAD:
-		error = profile_unload();
 		break;
 
 	case MOD_SHUTDOWN:
@@ -533,9 +529,11 @@
 	return (0);
 }
 
-SYSINIT(profile_load, SI_SUB_DTRACE_PROVIDER, SI_ORDER_ANY, profile_load, NULL)
+SYSINIT(profile_load, SI_SUB_DTRACE_PROVIDER, SI_ORDER_ANY, profile_load, NULL);
+SYSUNINIT(profile_unload, SI_SUB_DTRACE_PROVIDER, SI_ORDER_ANY, profile_unload, NULL);
 
 DEV_MODULE(profile, profile_modevent, NULL);
 MODULE_VERSION(profile, 1);
 MODULE_DEPEND(profile, dtrace, 1, 1, 1);
 MODULE_DEPEND(profile, cyclic, 1, 1, 1);
+MODULE_DEPEND(profile, opensolaris, 1, 1, 1);